feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Tighten the LdParser a bit

Browse Source 
Just a hotfix. This parser is still much too eager, and a lot of unit
tests only pass because it wrongly matches things that should be caught
elsewhere.

Fixes: QTCREATORBUG-25617
Change-Id: I91161a103b41239c3aac9e119c21e152b0437a32
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2021-04-22 15:00:40 +02:00
parent 5d9405a8ed
commit 7b408a9a7a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/ldparser.cpp
View File

@@ -116,7 +116,7 @@ Utils::OutputLineParser::Result LdParser::handleLine(const QString &line, Utils:
} }
match = m_regExpLinker.match(lne); match = m_regExpLinker.match(lne);
if (match.hasMatch()) { if (match.hasMatch() && lne.count(':') >= 2) {
bool ok; bool ok;
int lineno = match.captured(7).toInt(&ok); int lineno = match.captured(7).toInt(&ok);
if (!ok) if (!ok)