From 7b6ab79f3ecaea8e1c3796efe2cbfbf37e09a0a1 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 28 Oct 2020 12:10:55 +0100 Subject: [PATCH] ClangTools: Do not include our wrapped Qt headers These are only necessary for the code model and can prevent clazy from finding certain issues. Fixes: QTCREATORBUG-24845 Change-Id: I04ba6703812918c39ebbde1dbac5af85fe18622d Reviewed-by: David Schulz --- src/plugins/clangtools/clangtoolruncontrol.cpp | 2 +- src/plugins/cpptools/compileroptionsbuilder.cpp | 3 ++- src/plugins/cpptools/compileroptionsbuilder.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/plugins/clangtools/clangtoolruncontrol.cpp b/src/plugins/clangtools/clangtoolruncontrol.cpp index 738e98fa6ca..fda0b596ee2 100644 --- a/src/plugins/clangtools/clangtoolruncontrol.cpp +++ b/src/plugins/clangtools/clangtoolruncontrol.cpp @@ -121,7 +121,7 @@ AnalyzeUnit::AnalyzeUnit(const FileInfo &fileInfo, { CompilerOptionsBuilder optionsBuilder(*fileInfo.projectPart, UseSystemHeader::No, - UseTweakedHeaderPaths::Yes, + UseTweakedHeaderPaths::Tools, UseLanguageDefines::No, UseBuildSystemWarnings::No, clangVersion, diff --git a/src/plugins/cpptools/compileroptionsbuilder.cpp b/src/plugins/cpptools/compileroptionsbuilder.cpp index ff51c43504f..246298d98c1 100644 --- a/src/plugins/cpptools/compileroptionsbuilder.cpp +++ b/src/plugins/cpptools/compileroptionsbuilder.cpp @@ -298,7 +298,8 @@ void CompilerOptionsBuilder::enableExceptions() void CompilerOptionsBuilder::insertWrappedQtHeaders() { - insertWrappedHeaders(wrappedQtHeadersIncludePath()); + if (m_useTweakedHeaderPaths == UseTweakedHeaderPaths::Yes) + insertWrappedHeaders(wrappedQtHeadersIncludePath()); } void CompilerOptionsBuilder::insertWrappedMingwHeaders() diff --git a/src/plugins/cpptools/compileroptionsbuilder.h b/src/plugins/cpptools/compileroptionsbuilder.h index a83aba74666..af4663930f4 100644 --- a/src/plugins/cpptools/compileroptionsbuilder.h +++ b/src/plugins/cpptools/compileroptionsbuilder.h @@ -33,7 +33,7 @@ namespace CppTools { enum class UsePrecompiledHeaders : char { Yes, No }; enum class UseSystemHeader : char { Yes, No }; -enum class UseTweakedHeaderPaths : char { Yes, No }; +enum class UseTweakedHeaderPaths : char { Yes, Tools, No }; enum class UseToolchainMacros : char { Yes, No }; enum class UseLanguageDefines : char { Yes, No }; enum class UseBuildSystemWarnings : char { Yes, No };