From 7b8f5d98153b7e8562106376ffe3600d96ceb583 Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@theqtcompany.com>
Date: Wed, 15 Jul 2015 16:25:04 +0200
Subject: [PATCH] Clang: Improve conversion of QHash to QList

Change-Id: I5bea89d9a432240a131311b5fed537a46b3be967
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
---
 .../clangcodemodel/clangcompletionassistprocessor.cpp    | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/plugins/clangcodemodel/clangcompletionassistprocessor.cpp b/src/plugins/clangcodemodel/clangcompletionassistprocessor.cpp
index 2f8076802d3..cc8b9d4ed1d 100644
--- a/src/plugins/clangcodemodel/clangcompletionassistprocessor.cpp
+++ b/src/plugins/clangcodemodel/clangcompletionassistprocessor.cpp
@@ -72,8 +72,6 @@ QList<AssistProposalItem *> toAssistProposalItems(const CodeCompletions &complet
 {
     static CPlusPlus::Icons m_icons; // de-deduplicate
 
-    QList<AssistProposalItem *> result;
-
     bool signalCompletion = false; // TODO
     bool slotCompletion = false; // TODO
 
@@ -179,10 +177,11 @@ QList<AssistProposalItem *> toAssistProposalItems(const CodeCompletions &complet
         }
     }
 
-    foreach (ClangAssistProposalItem *item, items.values())
-        result.append(item);
+    QList<AssistProposalItem *> results;
+    results.reserve(items.size());
+    std::copy(items.cbegin(), items.cend(), std::back_inserter(results));
 
-    return result;
+    return results;
 }
 
 bool isFunctionHintLikeCompletion(CodeCompletion::Kind kind)