From 7b94ac13ed5bc3f5402535700785120c69f292c4 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Wed, 10 Apr 2013 10:18:36 +0200 Subject: [PATCH] QmlDesigner.Model: Adding warnings The API is confusing so we give a warning. Change-Id: I7a26766609316772bebc3088d820d472243b2c74 Reviewed-by: Marco Bubke Reviewed-by: Robert Loehning --- src/plugins/qmldesigner/designercore/model/bindingproperty.cpp | 3 +++ src/plugins/qmldesigner/designercore/model/variantproperty.cpp | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/plugins/qmldesigner/designercore/model/bindingproperty.cpp b/src/plugins/qmldesigner/designercore/model/bindingproperty.cpp index 482a3e45d27..3346eef6a62 100644 --- a/src/plugins/qmldesigner/designercore/model/bindingproperty.cpp +++ b/src/plugins/qmldesigner/designercore/model/bindingproperty.cpp @@ -62,6 +62,9 @@ void BindingProperty::setExpression(const QString &expression) if (!isValid()) throw InvalidModelNodeException(__LINE__, __FUNCTION__, __FILE__); + if (isDynamic()) + qWarning() << "Calling BindingProperty::setExpression on dynamic property."; + if (name() == "id") { // the ID for a node is independent of the state, so it has to be set with ModelNode::setId throw InvalidPropertyException(__LINE__, __FUNCTION__, __FILE__, name()); } diff --git a/src/plugins/qmldesigner/designercore/model/variantproperty.cpp b/src/plugins/qmldesigner/designercore/model/variantproperty.cpp index 37800f1b52f..8c1bb0fd73f 100644 --- a/src/plugins/qmldesigner/designercore/model/variantproperty.cpp +++ b/src/plugins/qmldesigner/designercore/model/variantproperty.cpp @@ -61,6 +61,9 @@ void VariantProperty::setValue(const QVariant &value) if (!isValid()) throw InvalidModelNodeException(__LINE__, __FUNCTION__, __FILE__); + if (isDynamic()) + qWarning() << "Calling VariantProperty::setValue on dynamic property."; + if (value.isNull()) throw InvalidArgumentException(__LINE__, __FUNCTION__, __FILE__, name());