From 7bae0b9d66bdbe90b952dda2751317d3c0ca7a18 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 9 Aug 2021 11:22:26 +0200 Subject: [PATCH] SilverSearcher: Fix crash in output parser Neither parseFilePath nor parseText guarantee that index stays < outputSize. Change-Id: I087858cf6c1027fd04a7608c8ef10f4ce88348ef Reviewed-by: Przemyslaw Gorszkowski Reviewed-by: Orgad Shaneh --- src/plugins/silversearcher/silversearcheroutputparser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/silversearcher/silversearcheroutputparser.cpp b/src/plugins/silversearcher/silversearcheroutputparser.cpp index 88ec7cdde05..0dab3250f9a 100644 --- a/src/plugins/silversearcher/silversearcheroutputparser.cpp +++ b/src/plugins/silversearcher/silversearcheroutputparser.cpp @@ -46,7 +46,7 @@ QList SilverSearcherOutputParser::parse() continue; } parseFilePath(); - while (output[index] != '\n') { + while (index < outputSize && output[index] != '\n') { parseLineNumber(); if (index >= outputSize - 1) break;