diff --git a/src/libs/utils/aspects.cpp b/src/libs/utils/aspects.cpp index 5ed7efd439d..77368dd0dc6 100644 --- a/src/libs/utils/aspects.cpp +++ b/src/libs/utils/aspects.cpp @@ -2255,12 +2255,12 @@ BaseAspect *AspectContainer::aspect(Id id) const AspectContainer::const_iterator AspectContainer::begin() const { - return d->m_items.begin(); + return d->m_items.cbegin(); } AspectContainer::const_iterator AspectContainer::end() const { - return d->m_items.end(); + return d->m_items.cend(); } const QList &AspectContainer::aspects() const diff --git a/src/libs/utils/filesystemwatcher.cpp b/src/libs/utils/filesystemwatcher.cpp index 7eb5db4692f..8a73753afdc 100644 --- a/src/libs/utils/filesystemwatcher.cpp +++ b/src/libs/utils/filesystemwatcher.cpp @@ -111,7 +111,6 @@ bool WatchEntry::trigger(const QString &fileName) } using WatchEntryMap = QHash; -using WatchEntryMapIterator = WatchEntryMap::iterator; class FileSystemWatcherPrivate { @@ -300,8 +299,8 @@ void FileSystemWatcher::removeFiles(const QStringList &files) qDebug() << this << d->m_id << "removeFiles " << files; QStringList toRemove; for (const QString &file : files) { - WatchEntryMapIterator it = d->m_files.find(file); - if (it == d->m_files.end()) { + const auto it = d->m_files.constFind(file); + if (it == d->m_files.constEnd()) { qWarning("FileSystemWatcher: File %s is not watched.", qPrintable(file)); continue; } @@ -392,8 +391,8 @@ void FileSystemWatcher::removeDirectories(const QStringList &directories) QStringList toRemove; for (const QString &directory : directories) { - WatchEntryMapIterator it = d->m_directories.find(directory); - if (it == d->m_directories.end()) { + const auto it = d->m_directories.constFind(directory); + if (it == d->m_directories.constEnd()) { qWarning("FileSystemWatcher: Directory %s is not watched.", qPrintable(directory)); continue; } @@ -416,7 +415,7 @@ QStringList FileSystemWatcher::directories() const void FileSystemWatcher::slotFileChanged(const QString &path) { - const WatchEntryMapIterator it = d->m_files.find(path); + const auto it = d->m_files.find(path); if (it != d->m_files.end() && it.value().trigger(path)) { if (debug) qDebug() << this << "triggers on file " << path @@ -428,7 +427,7 @@ void FileSystemWatcher::slotFileChanged(const QString &path) void FileSystemWatcher::slotDirectoryChanged(const QString &path) { - const WatchEntryMapIterator it = d->m_directories.find(path); + const auto it = d->m_directories.find(path); if (it != d->m_directories.end() && it.value().trigger(path)) { if (debug) qDebug() << this << "triggers on dir " << path diff --git a/src/libs/utils/launchersocket.cpp b/src/libs/utils/launchersocket.cpp index 07d0b917d21..17f2d078020 100644 --- a/src/libs/utils/launchersocket.cpp +++ b/src/libs/utils/launchersocket.cpp @@ -534,8 +534,8 @@ void LauncherSocket::unregisterHandle(quintptr token) { QTC_ASSERT(!isCalledFromLaunchersThread(), return); QMutexLocker locker(&m_mutex); - auto it = m_handles.find(token); - if (it == m_handles.end()) + auto it = m_handles.constFind(token); + if (it == m_handles.constEnd()) return; // TODO: issue a warning LauncherHandle *launcherHandle = it.value(); diff --git a/src/libs/utils/settingsaccessor.cpp b/src/libs/utils/settingsaccessor.cpp index ff9cb114f17..2f50db9c254 100644 --- a/src/libs/utils/settingsaccessor.cpp +++ b/src/libs/utils/settingsaccessor.cpp @@ -388,8 +388,8 @@ QString VersionUpgrader::backupExtension() const QVariantMap VersionUpgrader::renameKeys(const QList &changes, QVariantMap map) const { for (const Change &change : changes) { - QVariantMap::iterator oldSetting = map.find(change.first); - if (oldSetting != map.end()) { + const auto oldSetting = map.constFind(change.first); + if (oldSetting != map.constEnd()) { map.insert(change.second, oldSetting.value()); map.erase(oldSetting); } diff --git a/src/libs/utils/treemodel.cpp b/src/libs/utils/treemodel.cpp index e2c62127b92..4bf9058515f 100644 --- a/src/libs/utils/treemodel.cpp +++ b/src/libs/utils/treemodel.cpp @@ -657,11 +657,11 @@ void TreeItem::insertChild(int pos, TreeItem *item) m_model->beginInsertRows(idx, pos, pos); item->m_parent = this; item->propagateModel(m_model); - m_children.insert(m_children.begin() + pos, item); + m_children.insert(m_children.cbegin() + pos, item); m_model->endInsertRows(); } else { item->m_parent = this; - m_children.insert(m_children.begin() + pos, item); + m_children.insert(m_children.cbegin() + pos, item); } } diff --git a/src/libs/utils/wizard.cpp b/src/libs/utils/wizard.cpp index dded70691b4..18554c457d0 100644 --- a/src/libs/utils/wizard.cpp +++ b/src/libs/utils/wizard.cpp @@ -724,8 +724,8 @@ void WizardProgress::removeItem(WizardProgressItem *item) { Q_D(WizardProgress); - QMap::iterator it = d->m_itemToItem.find(item); - if (it == d->m_itemToItem.end()) { + const auto it = d->m_itemToItem.constFind(item); + if (it == d->m_itemToItem.constEnd()) { qWarning("WizardProgress::removePage: Item is not a part of the wizard"); return; } @@ -765,8 +765,8 @@ void WizardProgress::removePage(int pageId) { Q_D(WizardProgress); - QMap::iterator it = d->m_pageToItem.find(pageId); - if (it == d->m_pageToItem.end()) { + const auto it = d->m_pageToItem.constFind(pageId); + if (it == d->m_pageToItem.constEnd()) { qWarning("WizardProgress::removePage: page is not a part of the wizard"); return; }