feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsCommand: Remove defaultWorkingRepository() getter

Browse Source 
It wasn't really broadly used.

Change-Id: If2e185a7d8d0f920f3ec7f507bf96dd81f4559b0
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-08-03 13:07:23 +02:00
parent a5683616b9
commit 7bd33bc247
3 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/git/gitclient.cpp
View File

@@ -740,8 +740,9 @@ class ConflictHandler final : public QObject
{ {
Q_OBJECT Q_OBJECT
public: public:
static void attachToCommand(VcsCommand *command, const QString &abortCommand = QString()) { static void attachToCommand(VcsCommand *command, const FilePath &workingDirectory,
auto handler = new ConflictHandler(command->defaultWorkingDirectory(), abortCommand); const QString &abortCommand = {}) {
auto handler = new ConflictHandler(workingDirectory, abortCommand);
handler->setParent(command); // delete when command goes out of scope handler->setParent(command); // delete when command goes out of scope
command->addFlags(VcsCommand::ExpectRepoChanges); command->addFlags(VcsCommand::ExpectRepoChanges);
@@ -3437,7 +3438,7 @@ VcsCommand *GitClient::vcsExecAbortable(const FilePath &workingDirectory,
// For rebase, Git might request an editor (which means the process keeps running until the // For rebase, Git might request an editor (which means the process keeps running until the
// user closes it), so run without timeout. // user closes it), so run without timeout.
command->addJob({vcsBinary(), arguments}, isRebase ? 0 : vcsTimeoutS()); command->addJob({vcsBinary(), arguments}, isRebase ? 0 : vcsTimeoutS());
ConflictHandler::attachToCommand(command, abortCommand); ConflictHandler::attachToCommand(command, workingDirectory, abortCommand);
if (isRebase) if (isRebase)
GitProgressParser::attachToCommand(command); GitProgressParser::attachToCommand(command);
command->execute(); command->execute();
@@ -3500,7 +3501,7 @@ void GitClient::stashPop(const FilePath &workingDirectory, const QString &stash)
arguments << stash; arguments << stash;
VcsCommand *cmd = vcsExec(workingDirectory, arguments, nullptr, true, VcsCommand *cmd = vcsExec(workingDirectory, arguments, nullptr, true,
VcsCommand::ExpectRepoChanges); VcsCommand::ExpectRepoChanges);
ConflictHandler::attachToCommand(cmd); ConflictHandler::attachToCommand(cmd, workingDirectory);
} }
bool GitClient::synchronousStashRestore(const FilePath &workingDirectory, bool GitClient::synchronousStashRestore(const FilePath &workingDirectory,

7
src/plugins/vcsbase/vcscommand.cpp
View File

@@ -120,7 +120,7 @@ VcsCommand::VcsCommand(const FilePath &workingDirectory, const Environment &envi
{ {
connect(&d->m_watcher, &QFutureWatcher<void>::canceled, this, &VcsCommand::cancel); connect(&d->m_watcher, &QFutureWatcher<void>::canceled, this, &VcsCommand::cancel);
VcsOutputWindow::setRepository(defaultWorkingDirectory().toString()); VcsOutputWindow::setRepository(d->m_defaultWorkingDirectory.toString());
VcsOutputWindow *outputWindow = VcsOutputWindow::instance(); // Keep me here, just to be sure it's not instantiated in other thread VcsOutputWindow *outputWindow = VcsOutputWindow::instance(); // Keep me here, just to be sure it's not instantiated in other thread
connect(this, &VcsCommand::append, outputWindow, [outputWindow](const QString &t) { connect(this, &VcsCommand::append, outputWindow, [outputWindow](const QString &t) {
outputWindow->append(t); outputWindow->append(t);
@@ -194,11 +194,6 @@ void VcsCommand::setDisplayName(const QString &name)
d->m_displayName = name; d->m_displayName = name;
} }
const FilePath &VcsCommand::defaultWorkingDirectory() const
{
return d->m_defaultWorkingDirectory;
}
void VcsCommand::addFlags(unsigned f) void VcsCommand::addFlags(unsigned f)
{ {
d->m_flags |= f; d->m_flags |= f;

2
src/plugins/vcsbase/vcscommand.h
View File

@@ -124,8 +124,6 @@ public:
void setDisplayName(const QString &name); void setDisplayName(const QString &name);
const Utils::FilePath &defaultWorkingDirectory() const;
void addJob(const Utils::CommandLine &command, int timeoutS, void addJob(const Utils::CommandLine &command, int timeoutS,
const Utils::FilePath &workingDirectory = {}, const Utils::FilePath &workingDirectory = {},
const Utils::ExitCodeInterpreter &interpreter = {}); const Utils::ExitCodeInterpreter &interpreter = {});