feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Use override consistently

Browse Source 
clang-tidy fixes from modernize-use-override check.

Change-Id: I06c9c0b27e178695328dc139a83203aec79528e4
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
This commit is contained in:
Tobias Hunger
2018-05-07 15:08:46 +02:00
parent 9ebfda4c03
commit 7bd94b1db2
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/android/androidbuildapkwidget.h
View File

@@ -47,7 +47,7 @@ class ANDROID_EXPORT AndroidBuildApkWidget : public ProjectExplorer::BuildStepCo
public:
AndroidBuildApkWidget(AndroidBuildApkStep *step);
~AndroidBuildApkWidget();
~AndroidBuildApkWidget() override;
private:
void setTargetSdk(const QString &sdk);
@@ -60,8 +60,8 @@ private:
void updateKeyStorePath(const QString &path);
void signPackageCheckBoxToggled(bool checked);
virtual QString summaryText() const;
virtual QString displayName() const;
QString summaryText() const override;
QString displayName() const override;
void setCertificates();
Ui::AndroidBuildApkWidget *m_ui;

2
src/plugins/android/androidconfigurations.h
View File

@@ -217,7 +217,7 @@ signals:
private:
friend class Android::Internal::AndroidPluginPrivate;
AndroidConfigurations();
~AndroidConfigurations();
~AndroidConfigurations() override;
void load();
void save();

6
src/plugins/android/androidpackageinstallationstep.h
View File

@@ -59,9 +59,9 @@ class AndroidPackageInstallationStepWidget : public ProjectExplorer::BuildStepCo
public:
AndroidPackageInstallationStepWidget(AndroidPackageInstallationStep *step);
QString summaryText() const;
QString displayName() const;
bool showWidget() const;
QString summaryText() const override;
QString displayName() const override;
bool showWidget() const override;
private:
AndroidPackageInstallationStep *m_step;
};

2
src/plugins/android/androidqtsupport.h
View File

@@ -47,7 +47,7 @@ class ANDROID_EXPORT AndroidQtSupport : public QObject
protected:
AndroidQtSupport();
~AndroidQtSupport();
~AndroidQtSupport() override;
public:
enum BuildType {

4
src/plugins/android/androidsdkpackage.h
View File

@@ -65,7 +65,7 @@ public:
};
AndroidSdkPackage(QVersionNumber revision, QString sdkStylePathStr, QObject *parent = nullptr);
virtual ~AndroidSdkPackage() { }
~AndroidSdkPackage() override { }
virtual bool isValid() const = 0;
virtual PackageType type() const = 0;
@@ -128,7 +128,7 @@ public:
SdkPlatform(QVersionNumber revision, QString sdkStylePathStr, int api,
QObject *parent = nullptr);
~SdkPlatform();
~SdkPlatform() override;
// AndroidSdkPackage Overrides
bool isValid() const override;