From 7c064d39211c5e63fb76aa7e27e20f936e6dcaba Mon Sep 17 00:00:00 2001
From: Laurent Montel <laurent.montel@kdab.com>
Date: Mon, 25 Sep 2017 15:31:08 +0200
Subject: [PATCH] CorePlugin: Clean forward declaration

Change-Id: I37c381bc26a29acae1bfe0e49f2772b4e92cf046
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
---
 src/plugins/coreplugin/actionmanager/actionmanager.h   |  1 -
 src/plugins/coreplugin/actionmanager/actionmanager_p.h |  6 ------
 src/plugins/coreplugin/actionmanager/commandmappings.h |  1 -
 src/plugins/coreplugin/basefilewizardfactory.h         |  2 --
 src/plugins/coreplugin/coreplugin.h                    |  1 -
 src/plugins/coreplugin/dialogs/newdialog.h             |  1 -
 src/plugins/coreplugin/dialogs/openwithdialog.h        |  1 -
 src/plugins/coreplugin/dialogs/saveitemsdialog.h       |  6 ------
 src/plugins/coreplugin/dialogs/shortcutsettings.h      |  2 --
 src/plugins/coreplugin/documentmanager.h               |  4 ----
 src/plugins/coreplugin/editormanager/editormanager.h   | 10 ----------
 src/plugins/coreplugin/editormanager/editorview.h      |  4 ----
 .../coreplugin/editormanager/openeditorswindow.h       |  2 --
 src/plugins/coreplugin/find/searchresultwindow.h       |  2 --
 src/plugins/coreplugin/icore.h                         |  2 --
 src/plugins/coreplugin/locator/locatorsettingspage.h   |  1 -
 src/plugins/coreplugin/locator/locatorwidget.h         |  3 ---
 src/plugins/coreplugin/mainwindow.h                    |  3 ---
 src/plugins/coreplugin/navigationwidget.h              |  1 -
 src/plugins/coreplugin/outputpanemanager.h             |  2 --
 src/plugins/coreplugin/rightpane.h                     |  1 -
 src/plugins/coreplugin/sidebarwidget.h                 |  2 --
 22 files changed, 58 deletions(-)

diff --git a/src/plugins/coreplugin/actionmanager/actionmanager.h b/src/plugins/coreplugin/actionmanager/actionmanager.h
index 2f29eac491a..e8c661b9899 100644
--- a/src/plugins/coreplugin/actionmanager/actionmanager.h
+++ b/src/plugins/coreplugin/actionmanager/actionmanager.h
@@ -35,7 +35,6 @@
 
 QT_BEGIN_NAMESPACE
 class QAction;
-class QSettings;
 class QString;
 QT_END_NAMESPACE
 
diff --git a/src/plugins/coreplugin/actionmanager/actionmanager_p.h b/src/plugins/coreplugin/actionmanager/actionmanager_p.h
index 0269fc4992e..5ac100ba784 100644
--- a/src/plugins/coreplugin/actionmanager/actionmanager_p.h
+++ b/src/plugins/coreplugin/actionmanager/actionmanager_p.h
@@ -34,18 +34,12 @@
 #include <QMultiHash>
 #include <QTimer>
 
-QT_BEGIN_NAMESPACE
-class QLabel;
-class QSettings;
-QT_END_NAMESPACE
-
 namespace Core {
 
 namespace Internal {
 
 class Action;
 class ActionContainerPrivate;
-class MainWindow;
 
 class ActionManagerPrivate : public QObject
 {
diff --git a/src/plugins/coreplugin/actionmanager/commandmappings.h b/src/plugins/coreplugin/actionmanager/commandmappings.h
index 89abe7efb08..ddfd7ff2809 100644
--- a/src/plugins/coreplugin/actionmanager/commandmappings.h
+++ b/src/plugins/coreplugin/actionmanager/commandmappings.h
@@ -30,7 +30,6 @@
 #include <QWidget>
 
 QT_BEGIN_NAMESPACE
-class QLineEdit;
 class QTreeWidget;
 class QTreeWidgetItem;
 QT_END_NAMESPACE
diff --git a/src/plugins/coreplugin/basefilewizardfactory.h b/src/plugins/coreplugin/basefilewizardfactory.h
index 61972f17e16..8e68fb07221 100644
--- a/src/plugins/coreplugin/basefilewizardfactory.h
+++ b/src/plugins/coreplugin/basefilewizardfactory.h
@@ -34,10 +34,8 @@
 #include <QVariantMap>
 
 QT_BEGIN_NAMESPACE
-class QIcon;
 class QWizard;
 class QWizardPage;
-class QDebug;
 QT_END_NAMESPACE
 
 namespace Utils { class Wizard; }
diff --git a/src/plugins/coreplugin/coreplugin.h b/src/plugins/coreplugin/coreplugin.h
index 7a69887c36a..2f86226a711 100644
--- a/src/plugins/coreplugin/coreplugin.h
+++ b/src/plugins/coreplugin/coreplugin.h
@@ -35,7 +35,6 @@ QT_END_NAMESPACE
 
 namespace Utils {
 class PathChooser;
-class Theme;
 }
 
 namespace Core {
diff --git a/src/plugins/coreplugin/dialogs/newdialog.h b/src/plugins/coreplugin/dialogs/newdialog.h
index 5d73546aa96..9461efae261 100644
--- a/src/plugins/coreplugin/dialogs/newdialog.h
+++ b/src/plugins/coreplugin/dialogs/newdialog.h
@@ -39,7 +39,6 @@ class QSortFilterProxyModel;
 class QPushButton;
 class QStandardItem;
 class QStandardItemModel;
-class QStringList;
 QT_END_NAMESPACE
 
 namespace Core {
diff --git a/src/plugins/coreplugin/dialogs/openwithdialog.h b/src/plugins/coreplugin/dialogs/openwithdialog.h
index d93ea71d6d2..a3f0db0366f 100644
--- a/src/plugins/coreplugin/dialogs/openwithdialog.h
+++ b/src/plugins/coreplugin/dialogs/openwithdialog.h
@@ -30,7 +30,6 @@
 
 namespace Core {
 
-class ICore;
 
 namespace Internal {
 
diff --git a/src/plugins/coreplugin/dialogs/saveitemsdialog.h b/src/plugins/coreplugin/dialogs/saveitemsdialog.h
index 1048ca03481..37d321fade8 100644
--- a/src/plugins/coreplugin/dialogs/saveitemsdialog.h
+++ b/src/plugins/coreplugin/dialogs/saveitemsdialog.h
@@ -30,18 +30,12 @@
 
 #include "ui_saveitemsdialog.h"
 
-QT_BEGIN_NAMESPACE
-class QCheckBox;
-QT_END_NAMESPACE
-
 namespace Core {
 
 class IDocument;
-class EditorManager;
 
 namespace Internal {
 
-class MainWindow;
 
 class SaveItemsDialog : public QDialog
 {
diff --git a/src/plugins/coreplugin/dialogs/shortcutsettings.h b/src/plugins/coreplugin/dialogs/shortcutsettings.h
index 4607d68419f..c3359f00648 100644
--- a/src/plugins/coreplugin/dialogs/shortcutsettings.h
+++ b/src/plugins/coreplugin/dialogs/shortcutsettings.h
@@ -36,7 +36,6 @@
 
 QT_BEGIN_NAMESPACE
 class QGroupBox;
-class QKeyEvent;
 class QLabel;
 QT_END_NAMESPACE
 
@@ -47,7 +46,6 @@ class Command;
 namespace Internal {
 
 class ActionManagerPrivate;
-class MainWindow;
 
 struct ShortcutItem
 {
diff --git a/src/plugins/coreplugin/documentmanager.h b/src/plugins/coreplugin/documentmanager.h
index 052a7ee7bd4..3cf9b47bfe7 100644
--- a/src/plugins/coreplugin/documentmanager.h
+++ b/src/plugins/coreplugin/documentmanager.h
@@ -32,16 +32,12 @@
 
 QT_BEGIN_NAMESPACE
 class QStringList;
-class QAction;
-class QMainWindow;
-class QMenu;
 QT_END_NAMESPACE
 
 namespace Utils { class FileName; }
 
 namespace Core {
 
-class IContext;
 class IDocument;
 
 namespace Internal {
diff --git a/src/plugins/coreplugin/editormanager/editormanager.h b/src/plugins/coreplugin/editormanager/editormanager.h
index 7c28c27eb70..7b467ac1ac0 100644
--- a/src/plugins/coreplugin/editormanager/editormanager.h
+++ b/src/plugins/coreplugin/editormanager/editormanager.h
@@ -41,15 +41,10 @@ namespace Utils { class MimeType; }
 
 namespace Core {
 
-class IContext;
 class IEditor;
 class IEditorFactory;
 class IExternalEditor;
 class IDocument;
-class IMode;
-class IVersionControl;
-
-class EditorToolBar;
 class SearchResultItem;
 
 enum MakeWritableResult {
@@ -60,13 +55,8 @@ enum MakeWritableResult {
 };
 
 namespace Internal {
-class EditorClosingCoreListener;
 class EditorManagerPrivate;
-class EditorView;
 class MainWindow;
-class OpenEditorsViewFactory;
-class OpenEditorsWindow;
-class SplitterOrView;
 } // namespace Internal
 
 class CORE_EXPORT EditorManagerPlaceHolder : public QWidget
diff --git a/src/plugins/coreplugin/editormanager/editorview.h b/src/plugins/coreplugin/editormanager/editorview.h
index abeb0f125e6..6653616efd8 100644
--- a/src/plugins/coreplugin/editormanager/editorview.h
+++ b/src/plugins/coreplugin/editormanager/editorview.h
@@ -41,8 +41,6 @@
 #include <functional>
 
 QT_BEGIN_NAMESPACE
-class QAction;
-class QComboBox;
 class QFrame;
 class QLabel;
 class QMenu;
@@ -53,11 +51,9 @@ class QToolButton;
 QT_END_NAMESPACE
 
 namespace Core {
-class IContext;
 class IDocument;
 class IEditor;
 class InfoBarDisplay;
-class DocumentModel;
 class EditorToolBar;
 
 namespace Internal {
diff --git a/src/plugins/coreplugin/editormanager/openeditorswindow.h b/src/plugins/coreplugin/editormanager/openeditorswindow.h
index e497411b771..9bd769bf8cc 100644
--- a/src/plugins/coreplugin/editormanager/openeditorswindow.h
+++ b/src/plugins/coreplugin/editormanager/openeditorswindow.h
@@ -39,7 +39,6 @@ QT_END_NAMESPACE
 
 namespace Core {
 
-class IDocument;
 class IEditor;
 
 namespace Internal {
@@ -51,7 +50,6 @@ public:
     QSize sizeHint() const;
 };
 
-class EditorHistoryItem;
 
 class OpenEditorsWindow : public QFrame
 {
diff --git a/src/plugins/coreplugin/find/searchresultwindow.h b/src/plugins/coreplugin/find/searchresultwindow.h
index f62c2163110..a22f6ad0a22 100644
--- a/src/plugins/coreplugin/find/searchresultwindow.h
+++ b/src/plugins/coreplugin/find/searchresultwindow.h
@@ -39,11 +39,9 @@ QT_END_NAMESPACE
 
 namespace Core {
 namespace Internal {
-    class SearchResultTreeView;
     class SearchResultWindowPrivate;
     class SearchResultWidget;
 }
-class Find;
 class SearchResultWindow;
 
 class CORE_EXPORT SearchResult : public QObject
diff --git a/src/plugins/coreplugin/icore.h b/src/plugins/coreplugin/icore.h
index b2d789b6d8d..89c6ada1808 100644
--- a/src/plugins/coreplugin/icore.h
+++ b/src/plugins/coreplugin/icore.h
@@ -44,9 +44,7 @@ namespace Core {
 class IWizardFactory;
 class Context;
 class IContext;
-class ProgressManager;
 class SettingsDatabase;
-class VcsManager;
 
 namespace Internal { class MainWindow; }
 
diff --git a/src/plugins/coreplugin/locator/locatorsettingspage.h b/src/plugins/coreplugin/locator/locatorsettingspage.h
index f9e4383d466..ed7143ae584 100644
--- a/src/plugins/coreplugin/locator/locatorsettingspage.h
+++ b/src/plugins/coreplugin/locator/locatorsettingspage.h
@@ -34,7 +34,6 @@
 #include <QPointer>
 
 QT_BEGIN_NAMESPACE
-class QListWidgetItem;
 class QSortFilterProxyModel;
 QT_END_NAMESPACE
 
diff --git a/src/plugins/coreplugin/locator/locatorwidget.h b/src/plugins/coreplugin/locator/locatorwidget.h
index c4ce3c4a14d..6b645134cce 100644
--- a/src/plugins/coreplugin/locator/locatorwidget.h
+++ b/src/plugins/coreplugin/locator/locatorwidget.h
@@ -34,10 +34,7 @@
 
 QT_BEGIN_NAMESPACE
 class QAction;
-class QLabel;
-class QLineEdit;
 class QMenu;
-class QTreeView;
 QT_END_NAMESPACE
 
 namespace Utils { class FancyLineEdit; }
diff --git a/src/plugins/coreplugin/mainwindow.h b/src/plugins/coreplugin/mainwindow.h
index 7a7042fd36a..a50fa8b6a7c 100644
--- a/src/plugins/coreplugin/mainwindow.h
+++ b/src/plugins/coreplugin/mainwindow.h
@@ -37,7 +37,6 @@
 #include <functional>
 
 QT_BEGIN_NAMESPACE
-class QSettings;
 class QPrinter;
 class QToolButton;
 QT_END_NAMESPACE
@@ -47,10 +46,8 @@ namespace Core {
 class StatusBarWidget;
 class EditorManager;
 class ExternalToolManager;
-class DocumentManager;
 class HelpManager;
 class IDocument;
-class IWizardFactory;
 class JsExpander;
 class MessageManager;
 class ModeManager;
diff --git a/src/plugins/coreplugin/navigationwidget.h b/src/plugins/coreplugin/navigationwidget.h
index e2b49ee95c0..0f43e4ce042 100644
--- a/src/plugins/coreplugin/navigationwidget.h
+++ b/src/plugins/coreplugin/navigationwidget.h
@@ -33,7 +33,6 @@
 QT_BEGIN_NAMESPACE
 class QSettings;
 class QAbstractItemModel;
-class QStandardItemModel;
 QT_END_NAMESPACE
 
 namespace Core {
diff --git a/src/plugins/coreplugin/outputpanemanager.h b/src/plugins/coreplugin/outputpanemanager.h
index b8885dd21d0..90dc7b04a0d 100644
--- a/src/plugins/coreplugin/outputpanemanager.h
+++ b/src/plugins/coreplugin/outputpanemanager.h
@@ -32,9 +32,7 @@
 
 QT_BEGIN_NAMESPACE
 class QAction;
-class QComboBox;
 class QLabel;
-class QSplitter;
 class QStackedWidget;
 class QTimeLine;
 class QLabel;
diff --git a/src/plugins/coreplugin/rightpane.h b/src/plugins/coreplugin/rightpane.h
index 4fb410f5eb9..ab3aab18e7d 100644
--- a/src/plugins/coreplugin/rightpane.h
+++ b/src/plugins/coreplugin/rightpane.h
@@ -36,7 +36,6 @@ QT_END_NAMESPACE
 
 namespace Core {
 
-class IMode;
 class RightPaneWidget;
 
 class CORE_EXPORT RightPanePlaceHolder : public QWidget
diff --git a/src/plugins/coreplugin/sidebarwidget.h b/src/plugins/coreplugin/sidebarwidget.h
index fbc6c09acca..e6db3c22006 100644
--- a/src/plugins/coreplugin/sidebarwidget.h
+++ b/src/plugins/coreplugin/sidebarwidget.h
@@ -28,10 +28,8 @@
 #include <QWidget>
 
 QT_BEGIN_NAMESPACE
-class QSettings;
 class QToolBar;
 class QAction;
-class QToolButton;
 QT_END_NAMESPACE
 
 namespace Core {