From 7c0ab5a40b09543d97395f300bf50ad27d153b61 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 17 Jan 2025 10:40:55 +0100 Subject: [PATCH] PerfProfiler: Replace essential with reverse dependency Having both: perfParserWorker -> perfRecordWorker and perfRecordWorker -> perfParserWorker dependencies have the same effect as "essential" property. This may fix the QdbPerfProfilerWorkerFactory case when stopping the recorded didn't necessarily stopped the parser. Change-Id: I8884deb453bffd65a84a2ba722924ff8352517ab Reviewed-by: hjk --- src/plugins/perfprofiler/perfprofilerruncontrol.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/plugins/perfprofiler/perfprofilerruncontrol.cpp b/src/plugins/perfprofiler/perfprofilerruncontrol.cpp index 70aa2f2308b..73c3d8b34aa 100644 --- a/src/plugins/perfprofiler/perfprofilerruncontrol.cpp +++ b/src/plugins/perfprofiler/perfprofilerruncontrol.cpp @@ -108,10 +108,6 @@ public: runner->setEnvironment(runControl->environment()); runControl->appendMessage("Starting Perf: " + cmd.toUserOutput(), NormalMessageFormat); }); - - // In the local case, the parser won't automatically stop when the recorder does. So we need - // to mark the recorder as essential, too. - runner->setEssential(true); return runner; }); @@ -143,6 +139,7 @@ public: perfParserWorker->addStartDependency(perfRecordWorker); perfParserWorker->addStopDependency(perfRecordWorker); + perfRecordWorker->addStopDependency(perfParserWorker); PerfProfilerTool::instance()->onWorkerCreation(runControl); auto tool = PerfProfilerTool::instance();