feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

WebAssembly: Fix "emrun --browser" call with latest emsdk

Browse Source 
emsdk's emrun now requires additional PATH entries in order to detect a
web browser location. At least on Windows.

Therefore, as a fix, use the build configuration environment instead of
an empty one for the emsdk call.

Fixes: QTCREATORBUG-27239
Change-Id: Ibe256265bd70f39693594f739403c415108fd981
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Alessandro Portale
2022-03-24 16:58:46 +01:00
parent b2866068ba
commit 7c4df8d23e
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/webassembly/webassemblyrunconfiguration.cpp
View File

@@ -124,6 +124,7 @@ public:
r.command = emrunCommand(runControl->runConfiguration(), r.command = emrunCommand(runControl->runConfiguration(),
browserId, browserId,
QString::number(portsGatherer->findEndPoint().port())); QString::number(portsGatherer->findEndPoint().port()));
r.environment = runControl->buildEnvironment();
SimpleTargetRunner::doStart(r, {}); SimpleTargetRunner::doStart(r, {});
}); });
} }