feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangTools: Avoid one use of mutable ProcessArgs::iterator

Browse Source 
splitArgs() is more compact and sufficient here.

Change-Id: I789b9ee37899b3d26bd4fabea7ab1756a6d8ac2b
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2021-05-06 15:26:33 +02:00
parent f2f40efa03
commit 7cb7e221bd
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/clangtools/clangtoolsutils.cpp
View File

@@ -321,21 +321,12 @@ ClangDiagnosticConfig diagnosticConfig(const Utils::Id &diagConfigId)
return configs.configWithId(diagConfigId); return configs.configWithId(diagConfigId);
} }
QStringList splitArgs(QString &argsString) static QStringList extraOptions(const char *envVar)
{
QStringList result;
Utils::ProcessArgs::ArgIterator it(&argsString);
while (it.next())
result.append(it.value());
return result;
}
QStringList extraOptions(const char *envVar)
{ {
if (!qEnvironmentVariableIsSet(envVar)) if (!qEnvironmentVariableIsSet(envVar))
return QStringList(); return QStringList();
QString arguments = QString::fromLocal8Bit(qgetenv(envVar)); QString arguments = qEnvironmentVariable(envVar);
return splitArgs(arguments); return Utils::ProcessArgs::splitArgs(arguments);
} }
QStringList extraClangToolsPrependOptions() QStringList extraClangToolsPrependOptions()