Move RemoveFileDialog to Utils

Change-Id: I88892fc8d43ca3f59598b5b44e0daac0bfb439b5
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Eike Ziller
2017-12-08 13:42:19 +01:00
parent b2a6899e56
commit 7cba5fc482
9 changed files with 24 additions and 22 deletions

View File

@@ -28,7 +28,7 @@
#include <QDir> #include <QDir>
using namespace Core; namespace Utils {
RemoveFileDialog::RemoveFileDialog(const QString &filePath, QWidget *parent) : RemoveFileDialog::RemoveFileDialog(const QString &filePath, QWidget *parent) :
QDialog(parent), QDialog(parent),
@@ -55,3 +55,5 @@ bool RemoveFileDialog::isDeleteFileChecked() const
{ {
return m_ui->deleteFileCheckBox->isChecked(); return m_ui->deleteFileCheckBox->isChecked();
} }
} // Utils

View File

@@ -25,15 +25,15 @@
#pragma once #pragma once
#include "core_global.h" #include "utils_global.h"
#include <QDialog> #include <QDialog>
namespace Core { namespace Utils {
namespace Ui { class RemoveFileDialog; } namespace Ui { class RemoveFileDialog; }
class CORE_EXPORT RemoveFileDialog : public QDialog class QTCREATOR_UTILS_EXPORT RemoveFileDialog : public QDialog
{ {
Q_OBJECT Q_OBJECT
@@ -48,4 +48,4 @@ private:
Ui::RemoveFileDialog *m_ui; Ui::RemoveFileDialog *m_ui;
}; };
} // namespace Core } // namespace Utils

View File

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<ui version="4.0"> <ui version="4.0">
<class>Core::RemoveFileDialog</class> <class>Utils::RemoveFileDialog</class>
<widget class="QDialog" name="Core::RemoveFileDialog"> <widget class="QDialog" name="Utils::RemoveFileDialog">
<property name="geometry"> <property name="geometry">
<rect> <rect>
<x>0</x> <x>0</x>
@@ -107,7 +107,7 @@
<connection> <connection>
<sender>buttonBox</sender> <sender>buttonBox</sender>
<signal>accepted()</signal> <signal>accepted()</signal>
<receiver>Core::RemoveFileDialog</receiver> <receiver>Utils::RemoveFileDialog</receiver>
<slot>accept()</slot> <slot>accept()</slot>
<hints> <hints>
<hint type="sourcelabel"> <hint type="sourcelabel">
@@ -123,7 +123,7 @@
<connection> <connection>
<sender>buttonBox</sender> <sender>buttonBox</sender>
<signal>rejected()</signal> <signal>rejected()</signal>
<receiver>Core::RemoveFileDialog</receiver> <receiver>Utils::RemoveFileDialog</receiver>
<slot>reject()</slot> <slot>reject()</slot>
<hints> <hints>
<hint type="sourcelabel"> <hint type="sourcelabel">

View File

@@ -120,7 +120,8 @@ SOURCES += \
$$PWD/textutils.cpp \ $$PWD/textutils.cpp \
$$PWD/url.cpp \ $$PWD/url.cpp \
$$PWD/filecrumblabel.cpp \ $$PWD/filecrumblabel.cpp \
$$PWD/fixedsizeclicklabel.cpp $$PWD/fixedsizeclicklabel.cpp \
$$PWD/removefiledialog.cpp
win32:SOURCES += $$PWD/consoleprocess_win.cpp win32:SOURCES += $$PWD/consoleprocess_win.cpp
else:SOURCES += $$PWD/consoleprocess_unix.cpp else:SOURCES += $$PWD/consoleprocess_unix.cpp
@@ -256,12 +257,14 @@ HEADERS += \
$$PWD/filecrumblabel.h \ $$PWD/filecrumblabel.h \
$$PWD/linecolumn.h \ $$PWD/linecolumn.h \
$$PWD/link.h \ $$PWD/link.h \
$$PWD/fixedsizeclicklabel.h $$PWD/fixedsizeclicklabel.h \
$$PWD/removefiledialog.h
FORMS += $$PWD/filewizardpage.ui \ FORMS += $$PWD/filewizardpage.ui \
$$PWD/projectintropage.ui \
$$PWD/newclasswidget.ui \ $$PWD/newclasswidget.ui \
$$PWD/proxycredentialsdialog.ui $$PWD/projectintropage.ui \
$$PWD/proxycredentialsdialog.ui \
$$PWD/removefiledialog.ui
RESOURCES += $$PWD/utils.qrc RESOURCES += $$PWD/utils.qrc

View File

@@ -193,6 +193,7 @@ Project {
"qtcprocess.h", "qtcprocess.h",
"reloadpromptutils.cpp", "reloadpromptutils.cpp",
"reloadpromptutils.h", "reloadpromptutils.h",
"removefiledialog.cpp", "removefiledialog.h", "removefiledialog.ui",
"runextensions.cpp", "runextensions.cpp",
"runextensions.h", "runextensions.h",
"savedaction.cpp", "savedaction.cpp",

View File

@@ -100,7 +100,6 @@ SOURCES += corejsextensions.cpp \
idocumentfactory.cpp \ idocumentfactory.cpp \
textdocument.cpp \ textdocument.cpp \
documentmanager.cpp \ documentmanager.cpp \
removefiledialog.cpp \
iversioncontrol.cpp \ iversioncontrol.cpp \
dialogs/addtovcsdialog.cpp \ dialogs/addtovcsdialog.cpp \
ioutputpane.cpp \ ioutputpane.cpp \
@@ -214,7 +213,6 @@ HEADERS += corejsextensions.h \
idocumentfactory.h \ idocumentfactory.h \
textdocument.h \ textdocument.h \
documentmanager.h \ documentmanager.h \
removefiledialog.h \
dialogs/addtovcsdialog.h \ dialogs/addtovcsdialog.h \
patchtool.h \ patchtool.h \
windowsupport.h \ windowsupport.h \
@@ -234,7 +232,6 @@ FORMS += dialogs/newdialog.ui \
dialogs/externaltoolconfig.ui \ dialogs/externaltoolconfig.ui \
mimetypesettingspage.ui \ mimetypesettingspage.ui \
mimetypemagicdialog.ui \ mimetypemagicdialog.ui \
removefiledialog.ui \
dialogs/addtovcsdialog.ui \ dialogs/addtovcsdialog.ui \
systemsettings.ui systemsettings.ui

View File

@@ -89,7 +89,6 @@ Project {
"patchtool.cpp", "patchtool.h", "patchtool.cpp", "patchtool.h",
"plugindialog.cpp", "plugindialog.h", "plugindialog.cpp", "plugindialog.h",
"reaper.cpp", "reaper.h", "reaper_p.h", "reaper.cpp", "reaper.h", "reaper_p.h",
"removefiledialog.cpp", "removefiledialog.h", "removefiledialog.ui",
"rightpane.cpp", "rightpane.h", "rightpane.cpp", "rightpane.h",
"settingsdatabase.cpp", "settingsdatabase.h", "settingsdatabase.cpp", "settingsdatabase.h",
"shellcommand.cpp", "shellcommand.h", "shellcommand.cpp", "shellcommand.h",

View File

@@ -113,7 +113,6 @@
#include <coreplugin/vcsmanager.h> #include <coreplugin/vcsmanager.h>
#include <coreplugin/iversioncontrol.h> #include <coreplugin/iversioncontrol.h>
#include <coreplugin/fileutils.h> #include <coreplugin/fileutils.h>
#include <coreplugin/removefiledialog.h>
#include <coreplugin/diffservice.h> #include <coreplugin/diffservice.h>
#include <texteditor/findinfiles.h> #include <texteditor/findinfiles.h>
#include <texteditor/textdocument.h> #include <texteditor/textdocument.h>
@@ -128,6 +127,7 @@
#include <utils/parameteraction.h> #include <utils/parameteraction.h>
#include <utils/processhandle.h> #include <utils/processhandle.h>
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
#include <utils/removefiledialog.h>
#include <utils/stringutils.h> #include <utils/stringutils.h>
#include <utils/utilsicons.h> #include <utils/utilsicons.h>
@@ -3221,7 +3221,7 @@ void ProjectExplorerPluginPrivate::removeProject()
return; return;
ProjectNode *projectNode = subProjectNode->managingProject(); ProjectNode *projectNode = subProjectNode->managingProject();
if (projectNode) { if (projectNode) {
RemoveFileDialog removeFileDialog(subProjectNode->filePath().toString(), ICore::mainWindow()); Utils::RemoveFileDialog removeFileDialog(subProjectNode->filePath().toString(), ICore::mainWindow());
removeFileDialog.setDeleteFileVisible(false); removeFileDialog.setDeleteFileVisible(false);
if (removeFileDialog.exec() == QDialog::Accepted) if (removeFileDialog.exec() == QDialog::Accepted)
projectNode->removeSubProject(subProjectNode->filePath().toString()); projectNode->removeSubProject(subProjectNode->filePath().toString());
@@ -3262,7 +3262,7 @@ void ProjectExplorerPluginPrivate::removeFile()
QTC_ASSERT(currentNode && currentNode->nodeType() == NodeType::File, return); QTC_ASSERT(currentNode && currentNode->nodeType() == NodeType::File, return);
const Utils::FileName filePath = currentNode->filePath(); const Utils::FileName filePath = currentNode->filePath();
RemoveFileDialog removeFileDialog(filePath.toString(), ICore::mainWindow()); Utils::RemoveFileDialog removeFileDialog(filePath.toString(), ICore::mainWindow());
if (removeFileDialog.exec() == QDialog::Accepted) { if (removeFileDialog.exec() == QDialog::Accepted) {
const bool deleteFile = removeFileDialog.isDeleteFileChecked(); const bool deleteFile = removeFileDialog.isDeleteFileChecked();

View File

@@ -28,10 +28,10 @@
#include <coreplugin/fileiconprovider.h> #include <coreplugin/fileiconprovider.h>
#include <coreplugin/fileutils.h> #include <coreplugin/fileutils.h>
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
#include <coreplugin/removefiledialog.h>
#include <coreplugin/vcsmanager.h> #include <coreplugin/vcsmanager.h>
#include <projectexplorer/projectexplorerconstants.h> #include <projectexplorer/projectexplorerconstants.h>
#include <utils/fileutils.h> #include <utils/fileutils.h>
#include <utils/removefiledialog.h>
#include <QCoreApplication> #include <QCoreApplication>
#include <QDebug> #include <QDebug>
@@ -1234,7 +1234,7 @@ EntryBackup * RelativeResourceModel::removeEntry(const QModelIndex &index)
deleteItem(index); deleteItem(index);
return new FileEntryBackup(*this, prefixIndex.row(), index.row(), fileNameBackup, aliasBackup); return new FileEntryBackup(*this, prefixIndex.row(), index.row(), fileNameBackup, aliasBackup);
} }
Core::RemoveFileDialog removeFileDialog(fileNameBackup, Core::ICore::mainWindow()); Utils::RemoveFileDialog removeFileDialog(fileNameBackup, Core::ICore::mainWindow());
if (removeFileDialog.exec() == QDialog::Accepted) { if (removeFileDialog.exec() == QDialog::Accepted) {
deleteItem(index); deleteItem(index);
Core::FileUtils::removeFile(fileNameBackup, removeFileDialog.isDeleteFileChecked()); Core::FileUtils::removeFile(fileNameBackup, removeFileDialog.isDeleteFileChecked());