From 7ccab9b54017d6d785d8f49fd58e55172a8835f8 Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Thu, 26 Feb 2015 23:19:21 +0200 Subject: [PATCH] MimeType: Improve performance for matchesName aliases() iterates through the entire hash. It should not be called so frequently. Change-Id: I2f896489459b2237a0a1763919fb8a52fb411ae1 Reviewed-by: Eike Ziller --- src/libs/utils/mimetypes/mimetype.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libs/utils/mimetypes/mimetype.cpp b/src/libs/utils/mimetypes/mimetype.cpp index ccaee2b6cd1..da76b8b1dff 100644 --- a/src/libs/utils/mimetypes/mimetype.cpp +++ b/src/libs/utils/mimetypes/mimetype.cpp @@ -432,7 +432,9 @@ QString MimeType::filterString() const bool MimeType::matchesName(const QString &nameOrAlias) const { - return d->name == nameOrAlias || aliases().contains(nameOrAlias); + if (d->name == nameOrAlias) + return true; + return MimeDatabasePrivate::instance()->provider()->resolveAlias(nameOrAlias) == d->name; } void MimeType::setPreferredSuffix(const QString &suffix)