From 7cf1ba2855691c5abe3763a872f2ed98a477c1fc Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 9 Feb 2018 14:29:28 +0100 Subject: [PATCH] RemoteLinux: Remove RemoteLinuxRunConfigFactory::canCreateHelper() It's only called from RunConfigurationFactory::create() in a context where the possible option are restricted to availableBuildTargets(), i.e. the check always succeeds, and that's what the base implementation does. Change-Id: Ie05abb64da9e9c765afc8a61d83095a709bc5c68 Reviewed-by: Christian Kandeler --- .../remotelinux/remotelinuxrunconfigurationfactory.cpp | 5 ----- src/plugins/remotelinux/remotelinuxrunconfigurationfactory.h | 1 - 2 files changed, 6 deletions(-) diff --git a/src/plugins/remotelinux/remotelinuxrunconfigurationfactory.cpp b/src/plugins/remotelinux/remotelinuxrunconfigurationfactory.cpp index 2f8ad457daf..3b191162a41 100644 --- a/src/plugins/remotelinux/remotelinuxrunconfigurationfactory.cpp +++ b/src/plugins/remotelinux/remotelinuxrunconfigurationfactory.cpp @@ -50,11 +50,6 @@ RemoteLinuxRunConfigurationFactory::RemoteLinuxRunConfigurationFactory(QObject * setSupportedTargetDeviceTypes({RemoteLinux::Constants::GenericLinuxOsType}); } -bool RemoteLinuxRunConfigurationFactory::canCreateHelper(Target *parent, const QString &buildTarget) const -{ - return parent->applicationTargets().hasTarget(buildTarget); -} - QList RemoteLinuxRunConfigurationFactory::availableCreators(Target *parent, CreationMode mode) const { diff --git a/src/plugins/remotelinux/remotelinuxrunconfigurationfactory.h b/src/plugins/remotelinux/remotelinuxrunconfigurationfactory.h index d3c68c41a7f..fd6a9682a10 100644 --- a/src/plugins/remotelinux/remotelinuxrunconfigurationfactory.h +++ b/src/plugins/remotelinux/remotelinuxrunconfigurationfactory.h @@ -37,7 +37,6 @@ class RemoteLinuxRunConfigurationFactory : public ProjectExplorer::IRunConfigura public: explicit RemoteLinuxRunConfigurationFactory(QObject *parent = nullptr); - bool canCreateHelper(ProjectExplorer::Target *parent, const QString &suffix) const override; QList availableCreators(ProjectExplorer::Target *parent, CreationMode mode) const override; };