feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Remove AspectContainer ctor's parent parameter

Browse Source 
Instead use setParent in the two cases that use it. The parent gets
in the way when attempting to derive AspectContainer from BaseAspect.

Change-Id: I6079beb0e00334133da115b714bc5186064c6722
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2023-07-27 15:13:31 +02:00
parent 9d9e84296a
commit 7d08f96da5
6 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/copilot/copilotprojectpanel.cpp
View File

@@ -32,7 +32,8 @@ ProjectSettingsWidget *createCopilotProjectPanel(Project *project)
using namespace ProjectExplorer;
auto widget = new CopilotProjectSettingsWidget;
auto settings = new CopilotProjectSettings(project, widget);
auto settings = new CopilotProjectSettings(project);
settings->setParent(widget);
QObject::connect(widget,
&ProjectSettingsWidget::useGlobalSettingsChanged,

3
src/plugins/copilot/copilotsettings.cpp
View File

@@ -91,8 +91,7 @@ CopilotSettings::CopilotSettings()
readSettings();
}
CopilotProjectSettings::CopilotProjectSettings(ProjectExplorer::Project *project, QObject *parent)
: AspectContainer(parent)
CopilotProjectSettings::CopilotProjectSettings(ProjectExplorer::Project *project)
{
setAutoApply(true);

2
src/plugins/copilot/copilotsettings.h
View File

@@ -25,7 +25,7 @@ CopilotSettings &settings();
class CopilotProjectSettings : public Utils::AspectContainer
{
public:
CopilotProjectSettings(ProjectExplorer::Project *project, QObject *parent = nullptr);
explicit CopilotProjectSettings(ProjectExplorer::Project *project);
void save(ProjectExplorer::Project *project);
void setUseGlobalSettings(bool useGlobalSettings);