feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

fold m_qmakespecFull back into m_qmakespec

Browse Source 
the original value is not used any more after the final resolution.

Change-Id: Icadc219f045a1bbfd20506c4c72c53d1fb352969
(cherry picked from qttools/74d548c89dae83b392953f505876d8d383a72ce5,
plus creator-specific amend)
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This commit is contained in:
Oswald Buddenhagen
2012-09-18 10:54:52 +02:00
parent eba7efa3c6
commit 7d4e3b7b4c
3 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/shared/proparser/profileevaluator.cpp
View File

@@ -204,7 +204,7 @@ QString ProFileEvaluator::propertyValue(const QString &name) const
QString ProFileEvaluator::resolvedMkSpec() const QString ProFileEvaluator::resolvedMkSpec() const
{ {
return d->m_qmakespecFull; return d->m_qmakespec;
} }
#ifdef PROEVALUATOR_CUMULATIVE #ifdef PROEVALUATOR_CUMULATIVE

16
src/shared/proparser/qmakeevaluator.cpp
View File

@@ -195,7 +195,6 @@ void QMakeEvaluator::initFrom(const QMakeEvaluator &other)
m_valuemapStack = other.m_valuemapStack; m_valuemapStack = other.m_valuemapStack;
m_valuemapInited = true; m_valuemapInited = true;
m_qmakespec = other.m_qmakespec; m_qmakespec = other.m_qmakespec;
m_qmakespecFull = other.m_qmakespecFull;
m_qmakespecName = other.m_qmakespecName; m_qmakespecName = other.m_qmakespecName;
m_mkspecPaths = other.m_mkspecPaths; m_mkspecPaths = other.m_mkspecPaths;
m_featureRoots = other.m_featureRoots; m_featureRoots = other.m_featureRoots;
@@ -1053,16 +1052,17 @@ bool QMakeEvaluator::loadSpecInternal()
return false; return false;
} }
#ifdef Q_OS_UNIX #ifdef Q_OS_UNIX
m_qmakespecFull = QFileInfo(m_qmakespec).canonicalFilePath(); m_qmakespec = QFileInfo(m_qmakespec).canonicalFilePath();
#else #else
// We can't resolve symlinks as they do on Unix, so configure.exe puts // We can't resolve symlinks as they do on Unix, so configure.exe puts
// the source of the qmake.conf at the end of the default/qmake.conf in // the source of the qmake.conf at the end of the default/qmake.conf in
// the QMAKESPEC_ORIGINAL variable. // the QMAKESPEC_ORIGINAL variable.
const ProString &orig_spec = first(ProKey("QMAKESPEC_ORIGINAL")); const ProString &orig_spec = first(ProKey("QMAKESPEC_ORIGINAL"));
m_qmakespecFull = orig_spec.isEmpty() ? m_qmakespec : orig_spec.toQString(); if (!orig_spec.isEmpty())
m_qmakespec = orig_spec.toQString();
#endif #endif
valuesRef(ProKey("QMAKESPEC")) << ProString(m_qmakespecFull); valuesRef(ProKey("QMAKESPEC")) << ProString(m_qmakespec);
m_qmakespecName = IoUtils::fileName(m_qmakespecFull).toString(); m_qmakespecName = IoUtils::fileName(m_qmakespec).toString();
if (!evaluateFeatureFile(QLatin1String("spec_post.prf"))) if (!evaluateFeatureFile(QLatin1String("spec_post.prf")))
return false; return false;
// The MinGW and x-build specs may change the separator; $$shell_{path,quote}() need it // The MinGW and x-build specs may change the separator; $$shell_{path,quote}() need it
@@ -1324,12 +1324,12 @@ void QMakeEvaluator::updateFeaturePaths()
foreach (const QString &item, m_qmakepath) foreach (const QString &item, m_qmakepath)
feature_bases << (item + mkspecs_concat); feature_bases << (item + mkspecs_concat);
if (!m_qmakespecFull.isEmpty()) { if (!m_qmakespec.isEmpty()) {
// The spec is already platform-dependent, so no subdirs here. // The spec is already platform-dependent, so no subdirs here.
feature_roots << (m_qmakespecFull + features_concat); feature_roots << (m_qmakespec + features_concat);
// Also check directly under the root directory of the mkspecs collection // Also check directly under the root directory of the mkspecs collection
QDir specdir(m_qmakespecFull); QDir specdir(m_qmakespec);
while (!specdir.isRoot() && specdir.cdUp()) { while (!specdir.isRoot() && specdir.cdUp()) {
const QString specpath = specdir.path(); const QString specpath = specdir.path();
if (specpath.endsWith(mkspecs_concat)) { if (specpath.endsWith(mkspecs_concat)) {

1
src/shared/proparser/qmakeevaluator.h
View File

@@ -221,7 +221,6 @@ public:
bool m_valuemapInited; bool m_valuemapInited;
bool m_hostBuild; bool m_hostBuild;
QString m_qmakespec; QString m_qmakespec;
QString m_qmakespecFull;
QString m_qmakespecName; QString m_qmakespecName;
QString m_superfile; QString m_superfile;
QString m_conffile; QString m_conffile;