From 7d689e63056b34d74aa9b685e46c9d5773a731bb Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@qt.io>
Date: Sat, 24 May 2025 16:15:54 +0200
Subject: [PATCH] QmlDesigner: Remove expensive checks in formeditor

Change-Id: I6a08f1446962c890b6e4e75060dd795b12b19157
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
---
 .../qmldesigner/components/formeditor/formeditorview.cpp     | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/plugins/qmldesigner/components/formeditor/formeditorview.cpp b/src/plugins/qmldesigner/components/formeditor/formeditorview.cpp
index 572436c4b40..ea24d1bd3e1 100644
--- a/src/plugins/qmldesigner/components/formeditor/formeditorview.cpp
+++ b/src/plugins/qmldesigner/components/formeditor/formeditorview.cpp
@@ -705,7 +705,8 @@ void FormEditorView::instancesCompleted(const QVector<ModelNode> &completedNodeL
     const bool isFlow = QmlItemNode(rootModelNode()).isFlowView();
     QList<FormEditorItem*> itemNodeList;
     for (const ModelNode &node : completedNodeList) {
-        if (const QmlItemNode qmlItemNode = (node)) {
+        if (node) {
+            const QmlItemNode qmlItemNode = node;
             if (FormEditorItem *item = scene()->itemForQmlItemNode(qmlItemNode)) {
                 scene()->synchronizeParent(qmlItemNode);
                 itemNodeList.append(item);
@@ -873,7 +874,7 @@ void FormEditorView::instancePropertyChanged(const QList<QPair<ModelNode, Proper
     for (auto &nodePropertyPair : propertyList) {
         const QmlItemNode qmlItemNode(nodePropertyPair.first);
         const PropertyName propertyName = nodePropertyPair.second;
-        if (qmlItemNode.isValid()) {
+        if (qmlItemNode.modelNode().isValid()) {
             if (FormEditorItem *item = scene()->itemForQmlItemNode(qmlItemNode)) {
                 static const PropertyNameList skipList({"x", "y", "width", "height"});
                 if (!skipList.contains(propertyName)) {