feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangTools: Remove pointless "Disable" setting for clang-tidy

Browse Source 
...as unchecking the root item in the tree has the same effect.

Change-Id: I960ea2c09a71dad3b0ba3dfb38a19055653354cd
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
Nikolai Kosjar
2019-10-24 10:25:52 +02:00
parent 0d7a30cdfe
commit 7d851c12ed
6 changed files with 21 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/clangtools/diagnosticconfigswidget.cpp
View File

@@ -812,21 +812,16 @@ void DiagnosticConfigsWidget::syncClangTidyWidgets(const ClangDiagnosticConfig &
disconnectClangTidyItemChanged();
ClangDiagnosticConfig::TidyMode tidyMode = config.clangTidyMode();
const int newIndex = tidyMode == ClangDiagnosticConfig::TidyMode::Default
? int(ClangDiagnosticConfig::TidyMode::ChecksPrefixList)
: int(tidyMode);
m_tidyChecks->tidyMode->setCurrentIndex(newIndex);
const ClangDiagnosticConfig::TidyMode tidyMode = config.clangTidyMode();
switch (tidyMode) {
case ClangDiagnosticConfig::TidyMode::Disabled:
case ClangDiagnosticConfig::TidyMode::File:
m_tidyChecks->tidyMode->setCurrentIndex(1);
m_tidyChecks->plainTextEditButton->setVisible(false);
m_tidyChecks->stackedWidget->setCurrentIndex(TidyPages::EmptyPage);
break;
case ClangDiagnosticConfig::TidyMode::ChecksPrefixList:
case ClangDiagnosticConfig::TidyMode::Default:
m_tidyChecks->tidyMode->setCurrentIndex(0);
if (m_tidyInfo.supportedChecks.isEmpty()) {
m_tidyChecks->plainTextEditButton->setVisible(false);
m_tidyChecks->stackedWidget->setCurrentIndex(TidyPages::InvalidExecutablePage);
@@ -926,8 +921,12 @@ void DiagnosticConfigsWidget::disconnectClazyItemChanged()
void DiagnosticConfigsWidget::onClangTidyModeChanged(int index)
{
const ClangDiagnosticConfig::TidyMode tidyMode
= index == 0 ? ClangDiagnosticConfig::TidyMode::ChecksPrefixList
: ClangDiagnosticConfig::TidyMode::File;
ClangDiagnosticConfig config = currentConfig();
config.setClangTidyMode(static_cast<ClangDiagnosticConfig::TidyMode>(index));
config.setClangTidyMode(tidyMode);
updateConfig(config);
syncClangTidyWidgets(config);
}