From 7dbf2c01c79e1e7ee78de4df3cb25bc54df21949 Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 18 Feb 2020 17:50:44 +0100 Subject: [PATCH] iOS: Some IosDeployStep cosmetics Change-Id: If9834af39b9c06373da472b3e0624051730f785a Reviewed-by: Eike Ziller --- src/plugins/ios/iosdeploystep.cpp | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/plugins/ios/iosdeploystep.cpp b/src/plugins/ios/iosdeploystep.cpp index 6609714e986..7bd5a879447 100644 --- a/src/plugins/ios/iosdeploystep.cpp +++ b/src/plugins/ios/iosdeploystep.cpp @@ -142,7 +142,7 @@ bool IosDeployStep::init() void IosDeployStep::doRun() { QTC_CHECK(m_transferStatus == NoTransfer); - if (device().isNull()) { + if (m_device.isNull()) { TaskHub::addTask( DeploymentTask(Task::Error, tr("Deployment failed. No iOS device found."))); emit finished(!iossimulator().isNull()); @@ -283,9 +283,9 @@ void IosDeployStep::checkProvisioningProfile() if (!provisionPlist.contains(QLatin1String("ProvisionedDevices"))) return; - QStringList deviceIds = provisionPlist.value(QLatin1String("ProvisionedDevices")).toStringList(); - QString targetId = device->uniqueDeviceID(); - foreach (const QString &deviceId, deviceIds) { + const QStringList deviceIds = provisionPlist.value("ProvisionedDevices").toStringList(); + const QString targetId = device->uniqueDeviceID(); + for (const QString &deviceId : deviceIds) { if (deviceId == targetId) return; } @@ -301,11 +301,6 @@ void IosDeployStep::checkProvisioningProfile() emit addTask(task); } -IDevice::ConstPtr IosDeployStep::device() const -{ - return m_device; -} - IosDevice::ConstPtr IosDeployStep::iosdevice() const { return m_device.dynamicCast();