From 7dc82dace640f5cc525dec1f38c582b3b5818c4b Mon Sep 17 00:00:00 2001
From: Henning Gruendl <henning.gruendl@qt.io>
Date: Tue, 15 Feb 2022 14:04:56 +0100
Subject: [PATCH] QmlDesigner: Add guard pointers to connect

Task-number: QDS-6239
Change-Id: I08a21a8c431046b846d0b41265d8665e93afa0a9
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
---
 src/plugins/studiowelcome/examplecheckout.cpp | 54 ++++++++++---------
 1 file changed, 28 insertions(+), 26 deletions(-)

diff --git a/src/plugins/studiowelcome/examplecheckout.cpp b/src/plugins/studiowelcome/examplecheckout.cpp
index 6bd1e2bded6..45d7dd440fb 100644
--- a/src/plugins/studiowelcome/examplecheckout.cpp
+++ b/src/plugins/studiowelcome/examplecheckout.cpp
@@ -146,7 +146,7 @@ void FileDownloader::start()
                          QNetworkRequest::UserVerifiedRedirectPolicy);
     QNetworkReply *reply = Utils::NetworkAccessManager::instance()->get(request);
 
-    QNetworkReply::connect(reply, &QNetworkReply::readyRead, [this, reply]() {
+    QNetworkReply::connect(reply, &QNetworkReply::readyRead, this, [this, reply]() {
         m_tempFile.write(reply->readAll());
     });
 
@@ -165,7 +165,7 @@ void FileDownloader::start()
         emit reply->redirectAllowed();
     });
 
-    QNetworkReply::connect(reply, &QNetworkReply::finished, [this, reply]() {
+    QNetworkReply::connect(reply, &QNetworkReply::finished, this, [this, reply]() {
         if (reply->error()) {
             m_tempFile.remove();
             qDebug() << Q_FUNC_INFO << m_url << reply->errorString();
@@ -246,7 +246,7 @@ void FileDownloader::probeUrl()
         emit reply->redirectAllowed();
     });
 
-    QNetworkReply::connect(reply, &QNetworkReply::finished, [this, reply]() {
+    QNetworkReply::connect(reply, &QNetworkReply::finished, this, [this, reply]() {
         if (reply->error())
             return;
 
@@ -259,6 +259,7 @@ void FileDownloader::probeUrl()
 
     QNetworkReply::connect(reply,
                            &QNetworkReply::errorOccurred,
+                           this,
                            [this, reply](QNetworkReply::NetworkError code) {
                                // QNetworkReply::HostNotFoundError
                                // QNetworkReply::ContentNotFoundError
@@ -282,7 +283,7 @@ FileExtractor::FileExtractor(QObject *parent)
     m_timer.setInterval(100);
     m_timer.setSingleShot(false);
 
-    QObject::connect(this, &FileExtractor::targetFolderExistsChanged, [this]() {
+    QObject::connect(this, &FileExtractor::targetFolderExistsChanged, this, [this]() {
         if (targetFolderExists()) {
             m_birthTime = QFileInfo(m_targetPath.toString() + "/" + m_archiveName).birthTime();
         } else
@@ -389,33 +390,34 @@ void FileExtractor::extract()
     qint64 bytesBefore = QStorageInfo(m_targetPath.toFileInfo().dir()).bytesAvailable();
     qint64 compressedSize = QFileInfo(m_sourceFile.toString()).size();
 
-    QTimer::connect(&m_timer, &QTimer::timeout, [this, bytesBefore, targetFolder, compressedSize]() {
-        static QHash<QString, int> hash;
-        QDirIterator it(targetFolder, {"*.*"}, QDir::Files, QDirIterator::Subdirectories);
+    QTimer::connect(
+        &m_timer, &QTimer::timeout, this, [this, bytesBefore, targetFolder, compressedSize]() {
+            static QHash<QString, int> hash;
+            QDirIterator it(targetFolder, {"*.*"}, QDir::Files, QDirIterator::Subdirectories);
 
-        int count = 0;
-        while (it.hasNext()) {
-            if (!hash.contains(it.fileName())) {
-                m_currentFile = it.fileName();
-                hash.insert(m_currentFile, 0);
-                emit currentFileChanged();
+            int count = 0;
+            while (it.hasNext()) {
+                if (!hash.contains(it.fileName())) {
+                    m_currentFile = it.fileName();
+                    hash.insert(m_currentFile, 0);
+                    emit currentFileChanged();
+                }
+                it.next();
+                count++;
             }
-            it.next();
-            count++;
-        }
 
-        qint64 currentSize = bytesBefore
-                             - QStorageInfo(m_targetPath.toFileInfo().dir()).bytesAvailable();
+            qint64 currentSize = bytesBefore
+                                 - QStorageInfo(m_targetPath.toFileInfo().dir()).bytesAvailable();
 
-        // We can not get the uncompressed size of the archive yet, that is why we use an
-        // approximation. We assume a 50% compression rate.
-        m_progress = std::min(100ll, currentSize * 100 / compressedSize * 2);
-        emit progressChanged();
+            // We can not get the uncompressed size of the archive yet, that is why we use an
+            // approximation. We assume a 50% compression rate.
+            m_progress = std::min(100ll, currentSize * 100 / compressedSize * 2);
+            emit progressChanged();
 
-        m_size = QString::number(currentSize);
-        m_count = QString::number(count);
-        emit sizeChanged();
-    });
+            m_size = QString::number(currentSize);
+            m_count = QString::number(count);
+            emit sizeChanged();
+        });
 
     QObject::connect(archive, &Utils::Archive::outputReceived, this, [this](const QString &output) {
         m_detailedText += output;