From 7e37ddd416f80ba178b67fcc32b7208d23ee92bb Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Wed, 25 Jan 2017 09:09:10 +0200 Subject: [PATCH] VcsCommand: Do not use QueuedConnection for the output proxy This causes messages reordering. For example: Amended "9036e2103c". 08:55 Executing in ...: git commit -F /tmp/QtCreator.i12936 --amend Change-Id: Ifb3466cdd0c441b7597339451661b416dcdc1fb4 Reviewed-by: Tobias Hunger --- src/plugins/vcsbase/vcscommand.cpp | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/plugins/vcsbase/vcscommand.cpp b/src/plugins/vcsbase/vcscommand.cpp index 85fef69ccc8..cf107697110 100644 --- a/src/plugins/vcsbase/vcscommand.cpp +++ b/src/plugins/vcsbase/vcscommand.cpp @@ -44,20 +44,15 @@ VcsCommand::VcsCommand(const QString &workingDirectory, VcsOutputWindow *outputWindow = VcsOutputWindow::instance(); connect(proxy, &Utils::OutputProxy::append, - outputWindow, [](const QString &txt) { VcsOutputWindow::append(txt); }, - Qt::QueuedConnection); + outputWindow, [](const QString &txt) { VcsOutputWindow::append(txt); }); connect(proxy, &Utils::OutputProxy::appendSilently, - outputWindow, &VcsOutputWindow::appendSilently, - Qt::QueuedConnection); + outputWindow, &VcsOutputWindow::appendSilently); connect(proxy, &Utils::OutputProxy::appendError, - outputWindow, &VcsOutputWindow::appendError, - Qt::QueuedConnection); + outputWindow, &VcsOutputWindow::appendError); connect(proxy, &Utils::OutputProxy::appendCommand, - outputWindow, &VcsOutputWindow::appendCommand, - Qt::QueuedConnection); + outputWindow, &VcsOutputWindow::appendCommand); connect(proxy, &Utils::OutputProxy::appendMessage, - outputWindow, &VcsOutputWindow::appendMessage, - Qt::QueuedConnection); + outputWindow, &VcsOutputWindow::appendMessage); return proxy; });