From 7e39f818c23d5233e240f90de6307d83edb38397 Mon Sep 17 00:00:00 2001 From: Li Xi Date: Fri, 17 Sep 2021 19:24:41 +0800 Subject: [PATCH] Delete unnecessary class instances OutlineWidgetStack inherits from QStackedWidget, so you don't need a member object like QStackedWidget. The m_Factory object is not used in the OutlineWidgetStack class, is of private type, and is not available in its OutlineWidgetStack derived class. Change-Id: I0b94a654dde023144f01e0bd7808ad5cc1dc92b8 Reviewed-by: David Schulz Reviewed-by: Eike Ziller --- src/plugins/texteditor/outlinefactory.cpp | 2 -- src/plugins/texteditor/outlinefactory.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/src/plugins/texteditor/outlinefactory.cpp b/src/plugins/texteditor/outlinefactory.cpp index 421479ab7a9..6590ccdce1f 100644 --- a/src/plugins/texteditor/outlinefactory.cpp +++ b/src/plugins/texteditor/outlinefactory.cpp @@ -62,8 +62,6 @@ void IOutlineWidgetFactory::updateOutline() namespace Internal { OutlineWidgetStack::OutlineWidgetStack(OutlineFactory *factory) : - QStackedWidget(), - m_factory(factory), m_syncWithEditor(true), m_sorted(false) { diff --git a/src/plugins/texteditor/outlinefactory.h b/src/plugins/texteditor/outlinefactory.h index d231b700de8..d32cefae8db 100644 --- a/src/plugins/texteditor/outlinefactory.h +++ b/src/plugins/texteditor/outlinefactory.h @@ -58,8 +58,6 @@ private: void updateEditor(Core::IEditor *editor); void updateCurrentEditor(); - QStackedWidget *m_widgetStack; - OutlineFactory *m_factory; QToolButton *m_toggleSync; QToolButton *m_filterButton; QToolButton *m_toggleSort;