Debugger: Remove unused WatchItem::state flag

Lately it was only set and read for debugging purposes. A mechanism
similar to the ChildrenNeeded state is still needed and available
through WatchItem::wantsChildren.

Change-Id: I78c85d65bc35810be420bd0418db9675473697cd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>

src/plugins/debugger/watchdata.h

@@ -60,26 +60,9 @@ public:
 
     WatchItem *parentItem() const;
 
-    enum State
-    {
-        ValueNeeded       = 2,
-        ChildrenNeeded    = 8,
-
-        InitialState = ValueNeeded | ChildrenNeeded
-    };
-
     static const qint64 InvalidId = -1;
 
-    void setAllUnneeded()          { state = State(0); }
-
-    bool isValueNeeded() const { return state & ValueNeeded; }
-    void setValueNeeded()      { state = State(state | ValueNeeded); }
-    void setValueUnneeded()    { state = State(state & ~ValueNeeded); }
-
-    bool isChildrenNeeded() const { return state & ChildrenNeeded; }
-    void setChildrenNeeded()   { state = State(state | ChildrenNeeded); }
-    void setChildrenUnneeded() { state = State(state & ~ChildrenNeeded); }
-    void setHasChildren(bool c)   { wantsChildren = c;  if (!c) setChildrenUnneeded(); }
+    void setHasChildren(bool c)   { wantsChildren = c; }
 
     bool isValid()   const { return !iname.isEmpty(); }
     bool isVTablePointer() const;
@@ -99,7 +82,6 @@ public:
 
 public:
     qint64          id;            // Token for the engine for internal mapping
-    qint32          state;         // 'needed' flags;
     QString         iname;         // Internal name sth like 'local.baz.public.a'
     QString         exp;           // The expression
     QString         name;          // Displayed name