feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

qmljs: Simplify code

Browse Source 
Should not have an impact on the behavior or performance iiuc.

Change-Id: I66f7b6773868a114c2c76fb2c0baca92cc58d0a9
Reviewed-by: Kevin Funk <kevin.funk@kdab.com>
This commit is contained in:
Kevin Funk
2020-12-03 20:40:49 +01:00
parent 5738418d41
commit 7e8d250fa6
1 changed files with 11 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/libs/qmljs/qmljsfindexportedcpptypes.cpp
View File

@@ -915,30 +915,17 @@ bool FindExportedCppTypes::maybeExportsTypes(const CPlusPlus::Document::Ptr &doc
{ {
if (!document->control()) if (!document->control())
return false; return false;
const QByteArray qmlRegisterSingletonTypeToken("qmlRegisterType"); const QByteArray tokens[] = {
const QByteArray qmlRegisterTypeToken("qmlRegisterSingletonType"); "qmlRegisterSingletonType",
const QByteArray qmlRegisterUncreatableTypeToken("qmlRegisterUncreatableType"); "qmlRegisterType",
const QByteArray qmlRegisterUncreatableMetaObjectToken("qmlRegisterUncreatableMetaObject"); "qmlRegisterUncreatableType",
const QByteArray setContextPropertyToken("setContextProperty"); "setContextProperty"
if (document->control()->findIdentifier( "qmlRegisterUncreatableMetaObject",
qmlRegisterTypeToken.constData(), qmlRegisterTypeToken.size())) { };
return true; for (const QByteArray &token : tokens) {
} if (document->control()->findIdentifier(token.constData(), token.size())) {
if (document->control()->findIdentifier( return true;
qmlRegisterSingletonTypeToken.constData(), qmlRegisterSingletonTypeToken.size())) { }
return true;
}
if (document->control()->findIdentifier(
qmlRegisterUncreatableTypeToken.constData(), qmlRegisterUncreatableTypeToken.size())) {
return true;
}
if (document->control()->findIdentifier(
setContextPropertyToken.constData(), setContextPropertyToken.size())) {
return true;
}
if (document->control()->findIdentifier(
qmlRegisterUncreatableMetaObjectToken.constData(), qmlRegisterUncreatableMetaObjectToken.size())) {
return true;
} }
return false; return false;
} }