feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Introduce a KitAspect::createManageButton() function

Browse Source 
Saves some repetition downstream.

Change-Id: Ied58586572d3e70669c9172c5076bbd12e211aa7
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2021-04-12 10:58:54 +02:00
parent 77481f25ce
commit 7eb9d8cb60
8 changed files with 30 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/mesonprojectmanager/settings/tools/kitaspect/toolkitaspectwidget.cpp
View File

@@ -29,7 +29,6 @@
#include "mesontoolkitaspect.h"
#include "ninjatoolkitaspect.h"
#include <coreplugin/icore.h>
#include <utils/qtcassert.h>
namespace MesonProjectManager {
@@ -40,7 +39,7 @@ ToolKitAspectWidget::ToolKitAspectWidget(ProjectExplorer::Kit *kit,
ToolType type)
: ProjectExplorer::KitAspectWidget(kit, ki)
, m_toolsComboBox(createSubWidget<QComboBox>())
, m_manageButton(createSubWidget<QPushButton>(KitAspectWidget::msgManage()))
, m_manageButton(createManageButton(Constants::SettingsPage::TOOLS_ID))
, m_type{type}
{
m_toolsComboBox->setSizePolicy(QSizePolicy::Ignored,
@@ -49,11 +48,6 @@ ToolKitAspectWidget::ToolKitAspectWidget(ProjectExplorer::Kit *kit,
m_toolsComboBox->setToolTip(ki->description());
loadTools();
m_manageButton->setContentsMargins(0, 0, 0, 0);
connect(m_manageButton, &QPushButton::clicked, this, [this]() {
Core::ICore::showOptionsDialog(Constants::SettingsPage::TOOLS_ID, m_manageButton);
});
connect(MesonTools::instance(),
&MesonTools::toolAdded,
this,

3
src/plugins/mesonprojectmanager/settings/tools/kitaspect/toolkitaspectwidget.h
View File

@@ -34,7 +34,6 @@
#include <QComboBox>
#include <QCoreApplication>
#include <QPushButton>
namespace MesonProjectManager {
namespace Internal {
@@ -83,7 +82,7 @@ private:
}
QComboBox *m_toolsComboBox;
QPushButton *m_manageButton;
QWidget *m_manageButton;
ToolType m_type;
};