feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Suppress 'unknown property' warning after finding an unknown type.

Browse Source 
And made the warnings/errors translatable.
This commit is contained in:
Erik Verbruggen
2010-02-18 14:24:46 +01:00
parent 9798dd7544
commit 7ee1bc5242
1 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/libs/qmljs/qmljscheck.cpp
View File

@@ -33,8 +33,20 @@
#include "qmljsevaluate.h"
#include "parser/qmljsast_p.h"
#include <QtGui/QApplication>
#include <QtCore/QDebug>
namespace QmlJS {
namespace Messages {
static const char *invalidPropertyName = QT_TRANSLATE_NOOP("QmlJS::Check", "'%1' is not a valid property name");
static const char *unknownType = QT_TRANSLATE_NOOP("QmlJS::Check", "unknown type");
} // namespace Messages
static inline QString tr(const char *msg)
{ return qApp->translate("QmlJS::Check", msg); }
} // namespace QmlJS
using namespace QmlJS;
using namespace QmlJS::AST;
using namespace QmlJS::Interpreter;
@@ -94,15 +106,15 @@ void Check::visitQmlObject(Node *ast, UiQualifiedId *typeId,
return;
}
const bool oldAllowAnyProperty = _allowAnyProperty;
if (! _context.lookupType(_doc.data(), typeId)) {
warning(typeId->identifierToken, QLatin1String("unknown type"));
// ### don't give up!
return;
warning(typeId->identifierToken, tr(Messages::unknownType));
_allowAnyProperty = true; // suppress subsequent "unknown property" errors
}
const ObjectValue *oldScopeObject = _context.qmlScopeObject();
const ObjectValue *oldExtraScope = _extraScope;
const bool oldAllowAnyProperty = _allowAnyProperty;
const ObjectValue *scopeObject = _doc->bind()->findQmlObject(ast);
_context.setQmlScopeObject(scopeObject);
@@ -205,8 +217,7 @@ void Check::checkScopeObjectMember(const UiQualifiedId *id)
value = _extraScope->lookupMember(propertyName, &_context);
if (!value) {
error(id->identifierToken,
QString("'%1' is not a valid property name").arg(propertyName));
return;
tr(Messages::invalidPropertyName).arg(propertyName));
}
// can't look up members for attached properties