feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Introduce a cache for pre-rendered value columne entries

Browse Source 
Change-Id: Ibdcac8a5ccaa3eab0723205b913056530c510280
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2023-02-24 12:17:03 +01:00
parent f2f5e4d030
commit 7f04a66546
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/debugger/watchdata.h
View File

@@ -78,6 +78,9 @@ public:
bool outdated = false; // \internal item is to be removed. bool outdated = false; // \internal item is to be removed.
double time = 0; // Time used on the dumper side to produce this item double time = 0; // Time used on the dumper side to produce this item
mutable QString valueCache; // Pre-computed displayed value
void updateValueCache() const; // implemented in watchhandler.cpp
private: private:
void parseHelper(const GdbMi &input, bool maySort); void parseHelper(const GdbMi &input, bool maySort);
}; };

19
src/plugins/debugger/watchhandler.cpp
View File

@@ -929,15 +929,22 @@ static QString displayName(const WatchItem *item)
return result; return result;
} }
static QString displayValue(const WatchItem *item)
void WatchItem::updateValueCache() const
{ {
QString result = truncateValue(formattedValue(item)); valueCache = truncateValue(formattedValue(this));
result = watchModel(item)->removeNamespaces(result); valueCache = watchModel(this)->removeNamespaces(valueCache);
if (result.isEmpty() && item->address) if (valueCache.isEmpty() && this->address)
result += QString::fromLatin1("@0x" + QByteArray::number(item->address, 16)); valueCache += QString::fromLatin1("@0x" + QByteArray::number(this->address, 16));
// if (origaddr) // if (origaddr)
// result += QString::fromLatin1(" (0x" + QByteArray::number(origaddr, 16) + ')'); // result += QString::fromLatin1(" (0x" + QByteArray::number(origaddr, 16) + ')');
return result; }
static QString displayValue(const WatchItem *item)
{
if (item->valueCache.isEmpty())
item->updateValueCache();
return item->valueCache;
} }
static QString displayType(const WatchItem *item) static QString displayType(const WatchItem *item)