Vcs: Move responsibility to set editor parameters to editor factory

So it doesn't need to be named twice in the editor factory setup.

This intentially includes a de-optimiztion: storing the parameters
by value, not by pointer. That's more natural, does not need to
keep the parameters alive on the caller side, and it's uncritical
in this context.

Change-Id: I92867d3f2f75c38911ae82d3eeb4759cba71b723
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/bazaar/commiteditor.cpp

@@ -35,8 +35,8 @@
 
 using namespace Bazaar::Internal;
 
-CommitEditor::CommitEditor(const VcsBase::VcsBaseSubmitEditorParameters *parameters) :
-    VcsBase::VcsBaseSubmitEditor(parameters, new BazaarCommitWidget)
+CommitEditor::CommitEditor() :
+    VcsBase::VcsBaseSubmitEditor(new BazaarCommitWidget)
 {
     document()->setPreferredDisplayName(tr("Commit Editor"));
 }