Vcs: Move responsibility to set editor parameters to editor factory

So it doesn't need to be named twice in the editor factory setup.

This intentially includes a de-optimiztion: storing the parameters
by value, not by pointer. That's more natural, does not need to
keep the parameters alive on the caller side, and it's uncritical
in this context.

Change-Id: I92867d3f2f75c38911ae82d3eeb4759cba71b723
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/subversion/subversionplugin.cpp

@@ -388,8 +388,7 @@ SubversionPluginPrivate::SubversionPluginPrivate()
     using namespace Core::Constants;
     Context context(SUBVERSION_CONTEXT);
 
-    new VcsSubmitEditorFactory(&submitParameters,
-        []() { return new SubversionSubmitEditor(&submitParameters); }, this);
+    new VcsSubmitEditorFactory(submitParameters, [] { return new SubversionSubmitEditor; }, this);
 
     const auto describeFunc = [this](const QString &source, const QString &id) {
         describe(source, id);

src/plugins/subversion/subversionsubmiteditor.cpp

@@ -32,8 +32,8 @@
 
 using namespace Subversion::Internal;
 
-SubversionSubmitEditor::SubversionSubmitEditor(const VcsBase::VcsBaseSubmitEditorParameters *parameters) :
-    VcsBase::VcsBaseSubmitEditor(parameters, new VcsBase::SubmitEditorWidget)
+SubversionSubmitEditor::SubversionSubmitEditor() :
+    VcsBase::VcsBaseSubmitEditor(new VcsBase::SubmitEditorWidget)
 {
     document()->setPreferredDisplayName(tr("Subversion Submit"));
     setDescriptionMandatory(false);

src/plugins/subversion/subversionsubmiteditor.h

@@ -36,7 +36,7 @@ class SubversionSubmitEditor : public VcsBase::VcsBaseSubmitEditor
 {
     Q_OBJECT
 public:
-    explicit SubversionSubmitEditor(const VcsBase::VcsBaseSubmitEditorParameters *parameters);
+    SubversionSubmitEditor();
 
     static QString fileFromStatusLine(const QString &statusLine);