From 7fa9316a965066f7143c451477d94cdb0aadb7da Mon Sep 17 00:00:00 2001 From: David Schulz Date: Thu, 20 Apr 2017 09:55:30 +0200 Subject: [PATCH] Debugger: Disable break on warning/fatal for cdb This seems to cause more trouble than benefit. Additionally this option is on the _gdb_ extended settings site. Task-number: QTCREATORBUG-17902 Change-Id: Ie548f68f84bffee670559b48f6a2ba259f8b8757 Reviewed-by: hjk --- src/plugins/debugger/cdb/cdbengine.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/plugins/debugger/cdb/cdbengine.cpp b/src/plugins/debugger/cdb/cdbengine.cpp index 36d129e8a94..54ce5c38573 100644 --- a/src/plugins/debugger/cdb/cdbengine.cpp +++ b/src/plugins/debugger/cdb/cdbengine.cpp @@ -727,14 +727,14 @@ void CdbEngine::runEngine() runCommand({breakAtFunctionCommand(wideFunc, module), BuiltinCommand, cb}); runCommand({breakAtFunctionCommand(QLatin1String(CdbOptionsPage::crtDbgReport), debugModule), BuiltinCommand, cb}); } - if (boolSetting(BreakOnWarning)) { - runCommand({"bm /( QtCored4!qWarning", BuiltinCommand}); // 'bm': All overloads. - runCommand({"bm /( Qt5Cored!QMessageLogger::warning", BuiltinCommand}); - } - if (boolSetting(BreakOnFatal)) { - runCommand({"bm /( QtCored4!qFatal", BuiltinCommand}); // 'bm': All overloads. - runCommand({"bm /( Qt5Cored!QMessageLogger::fatal", BuiltinCommand}); - } +// if (boolSetting(BreakOnWarning)) { +// runCommand({"bm /( QtCored4!qWarning", BuiltinCommand}); // 'bm': All overloads. +// runCommand({"bm /( Qt5Cored!QMessageLogger::warning", BuiltinCommand}); +// } +// if (boolSetting(BreakOnFatal)) { +// runCommand({"bm /( QtCored4!qFatal", BuiltinCommand}); // 'bm': All overloads. +// runCommand({"bm /( Qt5Cored!QMessageLogger::fatal", BuiltinCommand}); +// } if (runParameters().startMode == AttachCore) { QTC_ASSERT(!m_coreStopReason.isNull(), return; ); notifyEngineRunOkAndInferiorUnrunnable();