feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ScxmlEditor: Cleanup nullptr comparisons

Browse Source 
Change-Id: I8b61929f1d23a6a7c46043b8967c1aebe333a7e7
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Orgad Shaneh
2016-09-18 09:18:12 +03:00
committed by Orgad Shaneh
parent a9e796535a
commit 7fbbd8f2fd
9 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/scxmleditor/plugin_interface/scattributeitemmodel.cpp
View File

@@ -45,7 +45,7 @@ QVariant SCAttributeItemModel::headerData(int section, Qt::Orientation orientati
bool SCAttributeItemModel::setData(const QModelIndex &index, const QVariant &value, int role)
{
if (role != Qt::EditRole || m_tag == nullptr)
if (role != Qt::EditRole || !m_tag)
return false;
bool bEditable = m_tag->tagType() <= MetadataItem;
@@ -71,7 +71,7 @@ bool SCAttributeItemModel::setData(const QModelIndex &index, const QVariant &val
QVariant SCAttributeItemModel::data(const QModelIndex &index, int role) const
{
if (!index.isValid() || m_tag == nullptr)
if (!index.isValid() || !m_tag)
return QVariant();
if (index.row() < 0)
@@ -142,7 +142,7 @@ QVariant SCAttributeItemModel::data(const QModelIndex &index, int role) const
Qt::ItemFlags SCAttributeItemModel::flags(const QModelIndex &index) const
{
if (!index.isValid() || m_tag == nullptr)
if (!index.isValid() || !m_tag)
return Qt::NoItemFlags;
if (m_tag->tagType() <= MetadataItem || (index.column() == 1 && m_tag->info()->n_attributes > 0 && m_tag->info()->attributes[index.row()].editable))