feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Process: Remove no-op calls to setTimeoutS()

Browse Source 
The timeout is only used with runBlocking(), otherwise it's no-op.

Change-Id: I7d81e4a73c7182bd19c435c112a2d64c3f40ba2e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2024-01-21 10:51:43 +01:00
parent ce6087a591
commit 7fc991ac8e
2 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/android/androiddevice.cpp
View File

@@ -477,7 +477,6 @@ void AndroidDeviceManager::eraseAvd(const IDevice::Ptr &device, QWidget *parent)
const AndroidConfig &config = m_avdManager.config(); const AndroidConfig &config = m_avdManager.config();
const CommandLine command(config.avdManagerToolPath(), {"delete", "avd", "-n", name}); const CommandLine command(config.avdManagerToolPath(), {"delete", "avd", "-n", name});
qCDebug(androidDeviceLog).noquote() << "Running command (removeAvd):" << command.toUserOutput(); qCDebug(androidDeviceLog).noquote() << "Running command (removeAvd):" << command.toUserOutput();
m_removeAvdProcess->setTimeoutS(5);
m_removeAvdProcess->setEnvironment(config.toolsEnvironment()); m_removeAvdProcess->setEnvironment(config.toolsEnvironment());
m_removeAvdProcess->setCommand(command); m_removeAvdProcess->setCommand(command);
connect(m_removeAvdProcess.get(), &Process::done, this, [this, device] { connect(m_removeAvdProcess.get(), &Process::done, this, [this, device] {

1
src/plugins/git/gitclient.cpp
View File

@@ -3476,7 +3476,6 @@ QFuture<QVersionNumber> GitClient::gitVersion() const
proc->deleteLater(); proc->deleteLater();
}); });
proc->setTimeoutS(vcsTimeoutS());
proc->setEnvironment(processEnvironment()); proc->setEnvironment(processEnvironment());
proc->setCommand({newGitBinary, {"--version"}}); proc->setCommand({newGitBinary, {"--version"}});
proc->start(); proc->start();