feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BookMarks: Some code modernization

Browse Source 
Change-Id: Ifb39d67d69bb97f1516bcdc70da6ca118c797126
Reviewed-by: Christian Stenger <christian.stenger@digia.com>
This commit is contained in:
hjk
2014-10-15 12:25:29 +02:00
parent 7956107187
commit 80323dfb8e
4 changed files with 66 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/plugins/bookmarks/bookmarkmanager.cpp
View File

@@ -233,10 +233,8 @@ BookmarkView::BookmarkView(BookmarkManager *manager) :
setDragEnabled(true); setDragEnabled(true);
setDragDropMode(QAbstractItemView::DragOnly); setDragDropMode(QAbstractItemView::DragOnly);
connect(this, SIGNAL(clicked(QModelIndex)), connect(this, &QAbstractItemView::clicked, this, &BookmarkView::gotoBookmark);
this, SLOT(gotoBookmark(QModelIndex))); connect(this, &QAbstractItemView::activated, this, &BookmarkView::gotoBookmark);
connect(this, SIGNAL(activated(QModelIndex)),
this, SLOT(gotoBookmark(QModelIndex)));
} }
BookmarkView::~BookmarkView() BookmarkView::~BookmarkView()
@@ -266,16 +264,11 @@ void BookmarkView::contextMenuEvent(QContextMenuEvent *event)
if (model()->rowCount() == 0) if (model()->rowCount() == 0)
removeAll->setEnabled(false); removeAll->setEnabled(false);
connect(moveUp, SIGNAL(triggered()), connect(moveUp, &QAction::triggered, m_manager, &BookmarkManager::moveUp);
m_manager, SLOT(moveUp())); connect(moveDown, &QAction::triggered, m_manager, &BookmarkManager::moveDown);
connect(moveDown, SIGNAL(triggered()), connect(remove, &QAction::triggered, this, &BookmarkView::removeFromContextMenu);
m_manager, SLOT(moveDown())); connect(removeAll, &QAction::triggered, this, &BookmarkView::removeAll);
connect(remove, SIGNAL(triggered()), connect(edit, &QAction::triggered, m_manager, &BookmarkManager::edit);
this, SLOT(removeFromContextMenu()));
connect(removeAll, SIGNAL(triggered()),
this, SLOT(removeAll()));
connect(edit, SIGNAL(triggered()),
m_manager, SLOT(edit()));
menu.exec(mapToGlobal(event->pos())); menu.exec(mapToGlobal(event->pos()));
} }
@@ -332,11 +325,11 @@ BookmarkManager::BookmarkManager() :
m_bookmarkIcon(QLatin1String(":/bookmarks/images/bookmark.png")), m_bookmarkIcon(QLatin1String(":/bookmarks/images/bookmark.png")),
m_selectionModel(new QItemSelectionModel(this, this)) m_selectionModel(new QItemSelectionModel(this, this))
{ {
connect(Core::ICore::instance(), SIGNAL(contextChanged(QList<Core::IContext*>,Core::Context)), connect(Core::ICore::instance(), &ICore::contextChanged,
this, SLOT(updateActionStatus())); this, &BookmarkManager::updateActionStatus);
connect(SessionManager::instance(), SIGNAL(sessionLoaded(QString)), connect(SessionManager::instance(), &SessionManager::sessionLoaded,
this, SLOT(loadBookmarks())); this, &BookmarkManager::loadBookmarks);
updateActionStatus(); updateActionStatus();
} }
@@ -440,7 +433,7 @@ QMimeData *BookmarkManager::mimeData(const QModelIndexList &indexes) const
return data; return data;
} }
void BookmarkManager::toggleBookmark() void BookmarkManager::toggleBookmark(bool)
{ {
BaseTextEditor *editor = BaseTextEditor::currentTextEditor(); BaseTextEditor *editor = BaseTextEditor::currentTextEditor();
if (!editor) if (!editor)
@@ -706,7 +699,7 @@ void BookmarkManager::moveDown()
saveBookmarks(); saveBookmarks();
} }
void BookmarkManager::edit(const QString &fileName, int lineNumber) void BookmarkManager::editByFileAndLine(const QString &fileName, int lineNumber)
{ {
Bookmark *b = findBookmark(fileName, lineNumber); Bookmark *b = findBookmark(fileName, lineNumber);
QModelIndex current = selectionModel()->currentIndex(); QModelIndex current = selectionModel()->currentIndex();
@@ -731,8 +724,8 @@ void BookmarkManager::edit()
lineNumberSpinbox->setValue(b->lineNumber()); lineNumberSpinbox->setValue(b->lineNumber());
lineNumberSpinbox->setMaximumWidth(100); lineNumberSpinbox->setMaximumWidth(100);
auto buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel); auto buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel);
connect(buttonBox, SIGNAL(accepted()), &dlg, SLOT(accept())); connect(buttonBox, &QDialogButtonBox::accepted, &dlg, &QDialog::accept);
connect(buttonBox, SIGNAL(rejected()), &dlg, SLOT(reject())); connect(buttonBox, &QDialogButtonBox::rejected, &dlg, &QDialog::reject);
layout->addRow(tr("Note text:"), noteEdit); layout->addRow(tr("Note text:"), noteEdit);
layout->addRow(tr("Line number:"), lineNumberSpinbox); layout->addRow(tr("Line number:"), lineNumberSpinbox);
layout->addWidget(buttonBox); layout->addWidget(buttonBox);

8
src/plugins/bookmarks/bookmarkmanager.h
View File

@@ -100,8 +100,7 @@ public:
void handleBookmarkTooltipRequest(TextEditor::TextEditorWidget *widget, void handleBookmarkTooltipRequest(TextEditor::TextEditorWidget *widget,
const QPoint &pos, int line); const QPoint &pos, int line);
public slots: void toggleBookmark(bool);
void toggleBookmark();
void toggleBookmark(const QString &fileName, int lineNumber); void toggleBookmark(const QString &fileName, int lineNumber);
void nextInDocument(); void nextInDocument();
void prevInDocument(); void prevInDocument();
@@ -110,18 +109,17 @@ public slots:
void moveUp(); void moveUp();
void moveDown(); void moveDown();
void edit(); void edit();
void edit(const QString &fileName, int lineNumber); void editByFileAndLine(const QString &fileName, int lineNumber);
bool gotoBookmark(Bookmark *bookmark); bool gotoBookmark(Bookmark *bookmark);
signals: signals:
void updateActions(int state); void updateActions(int state);
void currentIndexChanged(const QModelIndex &); void currentIndexChanged(const QModelIndex &);
private slots: private:
void updateActionStatus(); void updateActionStatus();
void loadBookmarks(); void loadBookmarks();
private:
void documentPrevNext(bool next); void documentPrevNext(bool next);
Bookmark *findBookmark(const QString &filePath, int lineNumber); Bookmark *findBookmark(const QString &filePath, int lineNumber);

86
src/plugins/bookmarks/bookmarksplugin.cpp
View File

@@ -50,86 +50,94 @@
#include <QMenu> #include <QMenu>
using namespace Bookmarks::Constants; using namespace Bookmarks::Constants;
using namespace Bookmarks::Internal; using namespace Core;
using namespace TextEditor; using namespace TextEditor;
namespace Bookmarks {
namespace Internal {
BookmarksPlugin::BookmarksPlugin() BookmarksPlugin::BookmarksPlugin()
: m_bookmarkManager(0), : m_bookmarkManager(0),
m_bookmarkMarginActionLineNumber(0) m_bookmarkMarginActionLineNumber(0)
{ {
} }
void BookmarksPlugin::extensionsInitialized()
{
}
bool BookmarksPlugin::initialize(const QStringList & /*arguments*/, QString *) bool BookmarksPlugin::initialize(const QStringList & /*arguments*/, QString *)
{ {
Core::Context textcontext(TextEditor::Constants::C_TEXTEDITOR); Context textcontext(TextEditor::Constants::C_TEXTEDITOR);
Core::Context globalcontext(Core::Constants::C_GLOBAL); Context globalcontext(Core::Constants::C_GLOBAL);
Core::ActionContainer *mtools = Core::ActionManager::actionContainer(Core::Constants::M_TOOLS); ActionContainer *mtools = ActionManager::actionContainer(Core::Constants::M_TOOLS);
Core::ActionContainer *mbm = Core::ActionManager::createMenu(Core::Id(BOOKMARKS_MENU)); ActionContainer *mbm = ActionManager::createMenu(Id(BOOKMARKS_MENU));
mbm->menu()->setTitle(tr("&Bookmarks")); mbm->menu()->setTitle(tr("&Bookmarks"));
mtools->addMenu(mbm); mtools->addMenu(mbm);
//Toggle //Toggle
m_toggleAction = new QAction(tr("Toggle Bookmark"), this); m_toggleAction = new QAction(tr("Toggle Bookmark"), this);
Core::Command *cmd = Command *cmd = ActionManager::registerAction(m_toggleAction, BOOKMARKS_TOGGLE_ACTION, textcontext);
Core::ActionManager::registerAction(m_toggleAction, BOOKMARKS_TOGGLE_ACTION, textcontext); cmd->setDefaultKeySequence(QKeySequence(UseMacShortcuts ? tr("Meta+M") : tr("Ctrl+M")));
cmd->setDefaultKeySequence(QKeySequence(Core::UseMacShortcuts ? tr("Meta+M") : tr("Ctrl+M")));
mbm->addAction(cmd); mbm->addAction(cmd);
mbm->addSeparator(textcontext); mbm->addSeparator(textcontext);
//Previous //Previous
m_prevAction = new QAction(tr("Previous Bookmark"), this); m_prevAction = new QAction(tr("Previous Bookmark"), this);
cmd = Core::ActionManager::registerAction(m_prevAction, BOOKMARKS_PREV_ACTION, globalcontext); cmd = ActionManager::registerAction(m_prevAction, BOOKMARKS_PREV_ACTION, globalcontext);
cmd->setDefaultKeySequence(QKeySequence(Core::UseMacShortcuts ? tr("Meta+,") : tr("Ctrl+,"))); cmd->setDefaultKeySequence(QKeySequence(UseMacShortcuts ? tr("Meta+,") : tr("Ctrl+,")));
mbm->addAction(cmd); mbm->addAction(cmd);
//Next //Next
m_nextAction = new QAction(tr("Next Bookmark"), this); m_nextAction = new QAction(tr("Next Bookmark"), this);
cmd = Core::ActionManager::registerAction(m_nextAction, BOOKMARKS_NEXT_ACTION, globalcontext); cmd = ActionManager::registerAction(m_nextAction, BOOKMARKS_NEXT_ACTION, globalcontext);
cmd->setDefaultKeySequence(QKeySequence(Core::UseMacShortcuts ? tr("Meta+.") : tr("Ctrl+."))); cmd->setDefaultKeySequence(QKeySequence(UseMacShortcuts ? tr("Meta+.") : tr("Ctrl+.")));
mbm->addAction(cmd); mbm->addAction(cmd);
mbm->addSeparator(globalcontext); mbm->addSeparator(globalcontext);
//Previous Doc //Previous Doc
m_docPrevAction = new QAction(tr("Previous Bookmark in Document"), this); m_docPrevAction = new QAction(tr("Previous Bookmark in Document"), this);
cmd = Core::ActionManager::registerAction(m_docPrevAction, BOOKMARKS_PREVDOC_ACTION, globalcontext); cmd = ActionManager::registerAction(m_docPrevAction, BOOKMARKS_PREVDOC_ACTION, globalcontext);
mbm->addAction(cmd); mbm->addAction(cmd);
//Next Doc //Next Doc
m_docNextAction = new QAction(tr("Next Bookmark in Document"), this); m_docNextAction = new QAction(tr("Next Bookmark in Document"), this);
cmd = Core::ActionManager::registerAction(m_docNextAction, BOOKMARKS_NEXTDOC_ACTION, globalcontext); cmd = ActionManager::registerAction(m_docNextAction, BOOKMARKS_NEXTDOC_ACTION, globalcontext);
mbm->addAction(cmd); mbm->addAction(cmd);
m_editBookmarkAction = new QAction(tr("Edit Bookmark"), this); m_editBookmarkAction = new QAction(tr("Edit Bookmark"), this);
m_bookmarkManager = new BookmarkManager; m_bookmarkManager = new BookmarkManager;
connect(m_toggleAction, SIGNAL(triggered()), m_bookmarkManager, SLOT(toggleBookmark())); connect(m_toggleAction, &QAction::triggered, [this]() {
connect(m_prevAction, SIGNAL(triggered()), m_bookmarkManager, SLOT(prev())); if (BaseTextEditor *editor = BaseTextEditor::currentTextEditor())
connect(m_nextAction, SIGNAL(triggered()), m_bookmarkManager, SLOT(next())); m_bookmarkManager->toggleBookmark(editor->document()->filePath(), editor->currentLine());
connect(m_docPrevAction, SIGNAL(triggered()), m_bookmarkManager, SLOT(prevInDocument())); });
connect(m_docNextAction, SIGNAL(triggered()), m_bookmarkManager, SLOT(nextInDocument()));
connect(m_editBookmarkAction, SIGNAL(triggered()), this, SLOT(editBookmarkActionTriggered())); connect(m_prevAction, &QAction::triggered, m_bookmarkManager, &BookmarkManager::prev);
connect(m_bookmarkManager, SIGNAL(updateActions(int)), this, SLOT(updateActions(int))); connect(m_nextAction, &QAction::triggered, m_bookmarkManager, &BookmarkManager::next);
connect(m_docPrevAction, &QAction::triggered, m_bookmarkManager, &BookmarkManager::prevInDocument);
connect(m_docNextAction, &QAction::triggered, m_bookmarkManager, &BookmarkManager::nextInDocument);
connect(m_editBookmarkAction, &QAction::triggered, [this]() {
m_bookmarkManager->editByFileAndLine(m_bookmarkMarginActionFileName, m_bookmarkMarginActionLineNumber);
});
connect(m_bookmarkManager, &BookmarkManager::updateActions, this, &BookmarksPlugin::updateActions);
updateActions(m_bookmarkManager->state()); updateActions(m_bookmarkManager->state());
addAutoReleasedObject(new BookmarkViewFactory(m_bookmarkManager)); addAutoReleasedObject(new BookmarkViewFactory(m_bookmarkManager));
m_bookmarkMarginAction = new QAction(this); m_bookmarkMarginAction = new QAction(this);
m_bookmarkMarginAction->setText(tr("Toggle Bookmark")); m_bookmarkMarginAction->setText(tr("Toggle Bookmark"));
connect(m_bookmarkMarginAction, SIGNAL(triggered()), connect(m_bookmarkMarginAction, &QAction::triggered, [this]() {
this, SLOT(bookmarkMarginActionTriggered())); m_bookmarkManager->toggleBookmark(m_bookmarkMarginActionFileName,
m_bookmarkMarginActionLineNumber);
});
// EditorManager // EditorManager
connect(Core::EditorManager::instance(), SIGNAL(editorAboutToClose(Core::IEditor*)), connect(EditorManager::instance(), &EditorManager::editorAboutToClose,
this, SLOT(editorAboutToClose(Core::IEditor*))); this, &BookmarksPlugin::editorAboutToClose);
connect(Core::EditorManager::instance(), SIGNAL(editorOpened(Core::IEditor*)), connect(EditorManager::instance(), &EditorManager::editorOpened,
this, SLOT(editorOpened(Core::IEditor*))); this, &BookmarksPlugin::editorOpened);
return true; return true;
} }
@@ -151,7 +159,7 @@ void BookmarksPlugin::updateActions(int state)
m_docNextAction->setEnabled(hasdocbm); m_docNextAction->setEnabled(hasdocbm);
} }
void BookmarksPlugin::editorOpened(Core::IEditor *editor) void BookmarksPlugin::editorOpened(IEditor *editor)
{ {
if (auto widget = qobject_cast<TextEditorWidget *>(editor->widget())) { if (auto widget = qobject_cast<TextEditorWidget *>(editor->widget())) {
connect(widget, &TextEditorWidget::markRequested, connect(widget, &TextEditorWidget::markRequested,
@@ -165,7 +173,7 @@ void BookmarksPlugin::editorOpened(Core::IEditor *editor)
} }
} }
void BookmarksPlugin::editorAboutToClose(Core::IEditor *editor) void BookmarksPlugin::editorAboutToClose(IEditor *editor)
{ {
if (auto widget = qobject_cast<TextEditorWidget *>(editor->widget())) { if (auto widget = qobject_cast<TextEditorWidget *>(editor->widget())) {
connect(widget, &TextEditorWidget::markContextMenuRequested, connect(widget, &TextEditorWidget::markContextMenuRequested,
@@ -188,13 +196,5 @@ void BookmarksPlugin::requestContextMenu(TextEditorWidget *widget,
menu->addAction(m_editBookmarkAction); menu->addAction(m_editBookmarkAction);
} }
void BookmarksPlugin::bookmarkMarginActionTriggered() } // namespace Internal
{ } // namespace Bookmarks
m_bookmarkManager->toggleBookmark(m_bookmarkMarginActionFileName,
m_bookmarkMarginActionLineNumber);
}
void BookmarksPlugin::editBookmarkActionTriggered()
{
m_bookmarkManager->edit(m_bookmarkMarginActionFileName, m_bookmarkMarginActionLineNumber);
}

15
src/plugins/bookmarks/bookmarksplugin.h
View File

@@ -60,18 +60,13 @@ public:
~BookmarksPlugin(); ~BookmarksPlugin();
bool initialize(const QStringList &arguments, QString *errorMessage); bool initialize(const QStringList &arguments, QString *errorMessage);
void extensionsInitialized(); void extensionsInitialized() {}
public slots:
void updateActions(int stateMask);
private slots:
void editorOpened(Core::IEditor *editor);
void editorAboutToClose(Core::IEditor *editor);
void bookmarkMarginActionTriggered();
void editBookmarkActionTriggered();
private: private:
void updateActions(int stateMask);
void editorOpened(Core::IEditor *editor);
void editorAboutToClose(Core::IEditor *editor);
void requestContextMenu(TextEditor::TextEditorWidget *widget, void requestContextMenu(TextEditor::TextEditorWidget *widget,
int lineNumber, QMenu *menu); int lineNumber, QMenu *menu);