feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Project: Make setRequiredKitPredicate private

Browse Source 
Make calling Project::supportsKit(...) the default implementation.

Change-Id: I0e47972097e760e2ff3be229afb85eff839146b8
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Tobias Hunger
2018-02-16 12:26:58 +01:00
parent 9467ed42c3
commit 8059bf6204
10 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/cmakeproject.cpp
View File

@@ -376,7 +376,7 @@ bool CMakeProject::knowsAllBuildExecutables() const
return false;
}
bool CMakeProject::supportsKit(Kit *k, QString *errorMessage) const
bool CMakeProject::supportsKit(const Kit *k, QString *errorMessage) const
{
if (!CMakeKitInformation::cmakeTool(k)) {
if (errorMessage)

2
src/plugins/cmakeprojectmanager/cmakeproject.h
View File

@@ -72,7 +72,7 @@ public:
bool requiresTargetPanel() const final;
bool knowsAllBuildExecutables() const final;
bool supportsKit(ProjectExplorer::Kit *k, QString *errorMessage = 0) const final;
bool supportsKit(const ProjectExplorer::Kit *k, QString *errorMessage = nullptr) const final;
void runCMake();
void runCMakeAndScanProjectTree();