From 80aad7bdd47f1f206308c24f91209d91837a4e6c Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Tue, 21 Feb 2017 16:45:57 +0100 Subject: [PATCH] QmlDesigner: Do not check for warnings if validating If the rewriter is validating the changes come from the ui. Do not show warnings in this case, since this is simply annoying. Change-Id: Ia48233fbff26506c58e10ed2772212aac711f4fe Reviewed-by: Tim Jenssen --- .../qmldesigner/designercore/model/texttomodelmerger.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp b/src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp index 35cbf55c0f0..2732caa6ebb 100644 --- a/src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp +++ b/src/plugins/qmldesigner/designercore/model/texttomodelmerger.cpp @@ -913,6 +913,8 @@ bool TextToModelMerger::load(const QString &data, DifferenceHandler &differenceH { qCInfo(rewriterBenchmark) << Q_FUNC_INFO; + const bool justSanityCheck = !differenceHandler.isValidator(); + QTime time; if (rewriterBenchmark().isInfoEnabled()) time.start(); @@ -963,7 +965,8 @@ bool TextToModelMerger::load(const QString &data, DifferenceHandler &differenceH setActive(false); return false; } - m_rewriterView->setWarnings(warnings); + if (!justSanityCheck) + m_rewriterView->setWarnings(warnings); qCInfo(rewriterBenchmark) << "checked semantic errors:" << time.elapsed(); } setupUsedImports();