feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmakeProject: De-virtualize some QmakePriFile functions

Browse Source 
Some left-over from the time they were nodes. It's not used
polymorphically anymore.

Change-Id: I98e75eb5378abdf27e4538041b07c09fa1f9fcc5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
hjk
2017-12-20 17:48:37 +01:00
parent b4faec80ba
commit 80bd696270
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/qmakeprojectmanager/qmakeparsernodes.h
View File

@@ -132,17 +132,16 @@ public:
void update(const Internal::QmakePriFileEvalResult &result); void update(const Internal::QmakePriFileEvalResult &result);
// ProjectNode interface bool canAddSubProject(const QString &proFilePath) const;
virtual bool canAddSubProject(const QString &proFilePath) const;
virtual bool addSubProject(const QString &proFile); bool addSubProject(const QString &proFile);
virtual bool removeSubProjects(const QString &proFilePath); bool removeSubProjects(const QString &proFilePath);
virtual bool addFiles(const QStringList &filePaths, QStringList *notAdded = nullptr); bool addFiles(const QStringList &filePaths, QStringList *notAdded = nullptr);
virtual bool removeFiles(const QStringList &filePaths, QStringList *notRemoved = nullptr); bool removeFiles(const QStringList &filePaths, QStringList *notRemoved = nullptr);
virtual bool deleteFiles(const QStringList &filePaths); bool deleteFiles(const QStringList &filePaths);
virtual bool canRenameFile(const QString &filePath, const QString &newFilePath); bool canRenameFile(const QString &filePath, const QString &newFilePath);
virtual bool renameFile(const QString &filePath, const QString &newFilePath); bool renameFile(const QString &filePath, const QString &newFilePath);
bool setProVariable(const QString &var, const QStringList &values, bool setProVariable(const QString &var, const QStringList &values,
const QString &scope = QString(), const QString &scope = QString(),
@@ -150,7 +149,7 @@ public:
bool folderChanged(const QString &changedFolder, const QSet<Utils::FileName> &newFiles); bool folderChanged(const QString &changedFolder, const QSet<Utils::FileName> &newFiles);
virtual bool deploysFolder(const QString &folder) const; bool deploysFolder(const QString &folder) const;
QmakeProFile *proFile() const; QmakeProFile *proFile() const;
QVector<QmakePriFile *> subPriFilesExact() const; QVector<QmakePriFile *> subPriFilesExact() const;