feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Don't crash when trying to remove from empty bookmark list

Browse Source 
Fixes: QTCREATORBUG-32774
Change-Id: I74e77822051c794f4a932cbe5c064650bcafcf3b
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
hjk
2025-04-28 11:14:39 +02:00
parent 860e949e85
commit 80c348d00a
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/texteditor/bookmarkmanager.cpp
View File

@@ -648,6 +648,8 @@ void BookmarkManager::removeAllBookmarks()
void BookmarkManager::deleteBookmark(Bookmark *bookmark) void BookmarkManager::deleteBookmark(Bookmark *bookmark)
{ {
int idx = m_bookmarksList.indexOf(bookmark); int idx = m_bookmarksList.indexOf(bookmark);
if (idx < 0)
return;
beginRemoveRows(QModelIndex(), idx, idx); beginRemoveRows(QModelIndex(), idx, idx);
m_bookmarksMap[bookmark->filePath()].removeAll(bookmark); m_bookmarksMap[bookmark->filePath()].removeAll(bookmark);