feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DetailsWidget: Remove useless code

Browse Source 
setAlpha(...) takes an int, so due to rounding the alpha is actually
set to 0. Fixing that adds a rather ugly highlighting effect that we
don't want, so remove the code completely.

Change-Id: I61f06dcff7908ea1527c22e3c61ee6c027ed7553
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
Tobias Hunger
2012-06-06 22:52:14 +02:00
parent 80b40164f6
commit 8113465f41
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/libs/utils/detailswidget.cpp
View File

@@ -71,7 +71,7 @@ class DetailsWidgetPrivate
public:
DetailsWidgetPrivate(QWidget *parent);
QPixmap cacheBackground(const QSize &size, bool expanded);
QPixmap cacheBackground(const QSize &size);
void updateControls();
void changeHoverState(bool hovered);
@@ -133,7 +133,7 @@ DetailsWidgetPrivate::DetailsWidgetPrivate(QWidget *parent) :
m_grid->addWidget(m_additionalSummaryLabel, 1, 0, 1, 3);
}
QPixmap DetailsWidgetPrivate::cacheBackground(const QSize &size, bool expanded)
QPixmap DetailsWidgetPrivate::cacheBackground(const QSize &size)
{
QPixmap pixmap(size);
pixmap.fill(Qt::transparent);
@@ -150,11 +150,6 @@ QPixmap DetailsWidgetPrivate::cacheBackground(const QSize &size, bool expanded)
#endif
p.fillRect(fullRect, QColor(255, 255, 255, 40));
QColor highlight = q->palette().highlight().color();
highlight.setAlpha(0.5);
if (expanded)
p.fillRect(topRect, highlight);
QLinearGradient lg(topRect.topLeft(), topRect.bottomLeft());
lg.setColorAt(0, QColor(255, 255, 255, 130));
lg.setColorAt(1, QColor(255, 255, 255, 0));
@@ -274,12 +269,12 @@ void DetailsWidget::paintEvent(QPaintEvent *paintEvent)
if (d->m_state == Collapsed) {
if (d->m_collapsedPixmap.isNull() ||
d->m_collapsedPixmap.size() != size())
d->m_collapsedPixmap = d->cacheBackground(paintArea.size(), false);
d->m_collapsedPixmap = d->cacheBackground(paintArea.size());
p.drawPixmap(paintArea, d->m_collapsedPixmap);
} else {
if (d->m_expandedPixmap.isNull() ||
d->m_expandedPixmap.size() != size())
d->m_expandedPixmap = d->cacheBackground(paintArea.size(), true);
d->m_expandedPixmap = d->cacheBackground(paintArea.size());
p.drawPixmap(paintArea, d->m_expandedPixmap);
}
}