feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Add missing breaks in switch statements

Browse Source 
Detected by GCC7

Change-Id: Ic4a1f0adac486d3f6d0f7da15b24e983c17225f3
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Orgad Shaneh
2017-06-02 16:12:39 +03:00
committed by Orgad Shaneh
parent 48392fac9e
commit 8116cb39e1
3 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/debugger/debuggerprotocol.cpp
View File

@@ -660,6 +660,7 @@ QString decodeData(const QString &ba, const QString &encoding)
union { char c[8]; double d; } u = {{s[7], s[6], s[5], s[4], s[3], s[2], s[1], s[0]}}; union { char c[8]; double d; } u = {{s[7], s[6], s[5], s[4], s[3], s[2], s[1], s[0]}};
return QString::number(u.d); return QString::number(u.d);
} }
break;
} }
case DebuggerEncoding::IPv6AddressAndHexScopeId: { // 16 hex-encoded bytes, "%" and the string-encoded scope case DebuggerEncoding::IPv6AddressAndHexScopeId: { // 16 hex-encoded bytes, "%" and the string-encoded scope
const int p = ba.indexOf('%'); const int p = ba.indexOf('%');

1
src/plugins/debugger/qml/qmlcppengine.cpp
View File

@@ -630,6 +630,7 @@ void QmlCppEngine::slaveEngineStateChanged
case InferiorRunRequested: case InferiorRunRequested:
// can happen if qml engine was active // can happen if qml engine was active
notifyInferiorRunFailed(); notifyInferiorRunFailed();
break;
default: default:
CHECK_STATE(InferiorStopOk); CHECK_STATE(InferiorStopOk);
break; break;

3
src/plugins/debugger/registerhandler.cpp
View File

@@ -526,6 +526,7 @@ QVariant RegisterItem::data(int column, int role) const
return m_reg.value.toString(m_reg.kind, m_reg.size, m_format); return m_reg.value.toString(m_reg.kind, m_reg.size, m_format);
} }
} }
break;
case Qt::ToolTipRole: case Qt::ToolTipRole:
return QString("Current Value: %1\nPreviousValue: %2") return QString("Current Value: %1\nPreviousValue: %2")
@@ -577,6 +578,7 @@ QVariant RegisterSubItem::data(int column, int role) const
return ba; return ba;
} }
} }
break;
case Qt::ToolTipRole: case Qt::ToolTipRole:
if (m_subKind == IntegerRegister) { if (m_subKind == IntegerRegister) {
@@ -773,6 +775,7 @@ QVariant RegisterEditItem::data(int column, int role) const
.toString(m_subKind, m_subSize, m_subFormat, role == Qt::EditRole); .toString(m_subKind, m_subSize, m_subFormat, role == Qt::EditRole);
} }
} }
break;
case Qt::ToolTipRole: { case Qt::ToolTipRole: {
RegisterItem *registerItem = parent()->parent(); RegisterItem *registerItem = parent()->parent();
return RegisterHandler::tr("Edit bits %1...%2 of register %3") return RegisterHandler::tr("Edit bits %1...%2 of register %3")