Use less nullptr for empty flags

Change-Id: Ic4eafdc8f204a432a752a97593380609a408a7de
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/libs/utils/fancymainwindow.cpp

@@ -139,8 +139,8 @@ void DockWidgetTitleButton::paintEvent(QPaintEvent *)
     opt.init(this);
     opt.state |= QStyle::State_AutoRaise;
     opt.icon = icon();
-    opt.subControls = nullptr;
-    opt.activeSubControls = nullptr;
+    opt.subControls = {};
+    opt.activeSubControls = {};
     opt.features = QStyleOptionToolButton::None;
     opt.arrowType = Qt::NoArrow;
     int size = style()->pixelMetric(QStyle::PM_SmallIconSize, nullptr, this);

src/libs/utils/flowlayout.cpp

@@ -89,7 +89,7 @@ QLayoutItem *FlowLayout::takeAt(int index)
 
 Qt::Orientations FlowLayout::expandingDirections() const
 {
-    return nullptr;
+    return {};
 }
 
 bool FlowLayout::hasHeightForWidth() const

src/libs/utils/treemodel.cpp

@@ -1037,7 +1037,7 @@ bool BaseTreeModel::hasChildren(const QModelIndex &idx) const
 Qt::ItemFlags BaseTreeModel::flags(const QModelIndex &idx) const
 {
     if (!idx.isValid())
-        return nullptr;
+        return {};
     TreeItem *item = itemForIndex(idx);
     return item ? item->flags(idx.column())
                 : (Qt::ItemIsEnabled|Qt::ItemIsSelectable);

src/plugins/clangpchmanager/clangpchmanagerplugin.cpp

@@ -99,13 +99,13 @@ public:
         auto title = QCoreApplication::translate("ClangPchProgressManager",
                                                  "Creating PCHs",
                                                  "PCH stands for precompiled header");
-        Core::ProgressManager::addTask(promise.future(), title, "pch creation", nullptr);
+        Core::ProgressManager::addTask(promise.future(), title, "pch creation", {});
     }};
     ClangPchManager::ProgressManager dependencyCreationProgressManager{
         [](QFutureInterface<void> &promise) {
             auto title = QCoreApplication::translate("ClangPchProgressManager",
                                                      "Creating Dependencies");
-            Core::ProgressManager::addTask(promise.future(), title, "dependency creation", nullptr);
+            Core::ProgressManager::addTask(promise.future(), title, "dependency creation", {});
         }};
     ClangBackEnd::ProjectPartsStorage<Sqlite::Database> projectPartsStorage{database};
     PchManagerClient pchManagerClient{pchCreationProgressManager, dependencyCreationProgressManager};

src/plugins/clangrefactoring/qtcreatorsearchhandle.cpp

@@ -35,7 +35,7 @@ QtCreatorSearchHandle::QtCreatorSearchHandle(Core::SearchResult *searchResult)
     : searchResult(searchResult)
 {
     auto title = QCoreApplication::translate("QtCreatorSearchHandle", "Clang Query");
-    Core::ProgressManager::addTask(promise.future(), title, "clang query", nullptr);
+    Core::ProgressManager::addTask(promise.future(), title, "clang query", {});
 }
 
 void QtCreatorSearchHandle::addResult(const QString &fileName,

src/plugins/coreplugin/editormanager/openeditorsview.cpp

@@ -92,7 +92,7 @@ void OpenEditorsWidget::handleActivated(const QModelIndex &index)
         // work around a bug in itemviews where the delegate wouldn't get the QStyle::State_MouseOver
         QPoint cursorPos = QCursor::pos();
         QWidget *vp = viewport();
-        QMouseEvent e(QEvent::MouseMove, vp->mapFromGlobal(cursorPos), cursorPos, Qt::NoButton, nullptr, nullptr);
+        QMouseEvent e(QEvent::MouseMove, vp->mapFromGlobal(cursorPos), cursorPos, Qt::NoButton, {}, {});
         QCoreApplication::sendEvent(vp, &e);
     }
 }

src/plugins/cpptools/clangdiagnosticconfigswidget.cpp

@@ -61,7 +61,7 @@ public:
         : Utils::StaticTreeItem(text)
     {}
 
-    Qt::ItemFlags flags(int) const { return 0; }
+    Qt::ItemFlags flags(int) const { return {}; }
     QVariant data(int column, int role) const
     {
         if (role == Qt::ForegroundRole) {

src/plugins/cpptools/cppcodestylesettings.cpp

@@ -234,7 +234,7 @@ TextEditor::TabSettings CppCodeStyleSettings::currentGlobalTabSettings()
 static void configureOverviewWithCodeStyleSettings(CPlusPlus::Overview &overview,
                                                    const CppCodeStyleSettings &settings)
 {
-    overview.starBindFlags = CPlusPlus::Overview::StarBindFlags(nullptr);
+    overview.starBindFlags = {};
     if (settings.bindStarToIdentifier)
         overview.starBindFlags |= CPlusPlus::Overview::BindToIdentifier;
     if (settings.bindStarToTypeName)

src/plugins/debugger/sourcefileshandler.cpp

@@ -78,7 +78,7 @@ QVariant SourceFilesHandler::headerData(int section,
 Qt::ItemFlags SourceFilesHandler::flags(const QModelIndex &index) const
 {
     if (index.row() >= m_fullNames.size())
-        return nullptr;
+        return {};
     QFileInfo fi(m_fullNames.at(index.row()));
     return fi.isReadable() ? QAbstractItemModel::flags(index) : Qt::ItemFlags({});
 }

src/plugins/debugger/watchhandler.cpp

@@ -1178,7 +1178,7 @@ bool WatchModel::setData(const QModelIndex &idx, const QVariant &value, int role
 Qt::ItemFlags WatchModel::flags(const QModelIndex &idx) const
 {
     if (!idx.isValid())
-        return nullptr;
+        return {};
 
     const WatchItem *item = nonRootItemForIndex(idx);
     if (!item)

src/plugins/projectexplorer/projectmodels.cpp

@@ -178,7 +178,7 @@ QVariant FlatModel::data(const QModelIndex &index, int role) const
 Qt::ItemFlags FlatModel::flags(const QModelIndex &index) const
 {
     if (!index.isValid())
-        return nullptr;
+        return {};
     // We claim that everything is editable
     // That's slightly wrong
     // We control the only view, and that one does the checks

src/plugins/valgrind/callgrindvisualisation.cpp

@@ -97,7 +97,7 @@ FunctionGraphicsTextItem::FunctionGraphicsTextItem(const QString &text,
     , m_previousViewportDimension(0)
 {
     setFlag(QGraphicsItem::ItemIgnoresTransformations);
-    setAcceptedMouseButtons(nullptr); // do not steal focus from parent item
+    setAcceptedMouseButtons({}); // do not steal focus from parent item
     setToolTip(text);
 }