From 8129f886bcc50e91f55de15f751df183f0db822c Mon Sep 17 00:00:00 2001
From: Marco Bubke <marco.bubke@qt.io>
Date: Tue, 9 May 2023 13:07:36 +0200
Subject: [PATCH] QmlDesigner: Improve warning suppression

Can be removed with never compiler.

Change-Id: I3196acfc82e3ab53f0f72dec3b543f27b9bbe2e1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
---
 src/libs/sqlite/sqliteids.h            | 7 -------
 src/plugins/qmldesigner/CMakeLists.txt | 3 ++-
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/libs/sqlite/sqliteids.h b/src/libs/sqlite/sqliteids.h
index 7613a2df46f..e7a4f9fbae2 100644
--- a/src/libs/sqlite/sqliteids.h
+++ b/src/libs/sqlite/sqliteids.h
@@ -51,17 +51,10 @@ public:
         return first.id >= second.id;
     }
 
-#if defined(__GNUC__) && !defined(__clang__)
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
-#endif
     constexpr friend InternalIntegerType operator-(BasicId first, BasicId second)
     {
         return first.id - second.id;
     }
-#if defined(__GNUC__) && !defined(__clang__)
-#pragma GCC diagnostic pop
-#endif
 
     constexpr bool isValid() const { return id > 0; }
 
diff --git a/src/plugins/qmldesigner/CMakeLists.txt b/src/plugins/qmldesigner/CMakeLists.txt
index 00b8bddfbdb..be90de8ae2b 100644
--- a/src/plugins/qmldesigner/CMakeLists.txt
+++ b/src/plugins/qmldesigner/CMakeLists.txt
@@ -8,7 +8,8 @@ if (APPLE)
   set(QmlDesignerPluginInstallPrefix "${IDE_PLUGIN_PATH}/QmlDesigner")
 endif()
 
-
+add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,Clang>:-Wno-error=maybe-uninitialized>")
+add_compile_options("$<$<COMPILE_LANG_AND_ID:CXX,GNU>:-Wno-error=maybe-uninitialized>")
 
 add_qtc_library(QmlDesignerUtils STATIC
   DEPENDS