Analyzer: Slim down AnalyzerStartParameters

* SysRoot can always be determined from kit.
* Pass around RunMode as extra parameter
  not as part of AnalyzerStartParameters.
  That's closer to the pattern used elsewhere.
* Environment was always initialized from the runconfig's
  EnvironmentAspect. The tools can do that directly.
* Provide setter for display name for cases where
  it is not equal to RunConfiguration::displayName

Change-Id: I811a0d7cdeb55cc37a16a593b3942abb567a2150
Reviewed-by: BogDan Vatra <bogdan@kdab.com>
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>

src/plugins/valgrind/memchecktool.h

@@ -91,7 +91,8 @@ public:
     QWidget *createWidgets();
 
     MemcheckRunControl *createRunControl(const Analyzer::AnalyzerStartParameters &sp,
-        ProjectExplorer::RunConfiguration *runConfiguration);
+                                         ProjectExplorer::RunConfiguration *runConfiguration,
+                                         Core::Id runMode);
 
 private slots:
     void settingsDestroyed(QObject *settings);
@@ -115,11 +116,6 @@ private:
     void updateFromSettings();
     int updateUiAfterFinishedHelper();
 
-protected:
-    virtual MemcheckRunControl *createMemcheckRunControl(
-            const Analyzer::AnalyzerStartParameters &sp,
-            ProjectExplorer::RunConfiguration *runConfiguration);
-
 private:
     ValgrindBaseSettings *m_settings;
     QMenu *m_filterMenu;
@@ -138,16 +134,6 @@ private:
     QAction *m_goNext;
 };
 
-class MemcheckWithGdbTool : public MemcheckTool
-{
-public:
-    MemcheckWithGdbTool(QObject *parent);
-
-    MemcheckRunControl *createMemcheckRunControl(
-            const Analyzer::AnalyzerStartParameters &sp,
-            ProjectExplorer::RunConfiguration *runConfiguration) override;
-};
-
 } // namespace Internal
 } // namespace Valgrind