feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix crash

Browse Source 
The items in selection tool can be dangling. Therefore we check it
against all items in the scene.

Task-number: QDS-15146
Change-Id: I1008e6855f874bf4f9d6c2f615ecf6b628747666
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Thomas Hartmann
2025-04-09 13:54:57 +02:00
committed by Tim Jenssen
parent 6ee5e09680
commit 819ad98520
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/qmldesigner/components/formeditor/selectiontool.cpp
View File

@@ -223,9 +223,12 @@ void SelectionTool::itemsAboutToRemoved(const QList<FormEditorItem*> &itemList)
{ {
const QList<FormEditorItem *> current = items(); const QList<FormEditorItem *> current = items();
QList<FormEditorItem *> remaining = Utils::filtered(current, [&itemList](FormEditorItem *item) { const auto allItems = scene()->items();
return !itemList.contains(item); QList<FormEditorItem *> remaining = Utils::filtered(current,
}); [&itemList, &allItems](FormEditorItem *item) {
return !itemList.contains(item)
&& allItems.contains(item);
});
if (!remaining.isEmpty()) { if (!remaining.isEmpty()) {
m_selectionIndicator.setItems(remaining); m_selectionIndicator.setItems(remaining);