feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: FsEngine micro-optimizations

Browse Source 
Mostly for shorter code, but also save a few cycles due to less
string construction and run time dispatch.

Also, make testFilePathFromToString() test two paths instead one path
twice.

Change-Id: I50a3145bca1a4b262a15e96173ea7ebd9cb678ad
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
hjk
2022-11-29 10:28:37 +01:00
parent f7d022009b
commit 8249eabbad
7 changed files with 46 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
src/libs/utils/filepath.cpp
View File

@@ -200,8 +200,8 @@ QString FilePath::toString() const
return path();
if (isRelativePath())
return scheme() + "://" + encodedHost() + "/./" + path();
return scheme() + "://" + encodedHost() + path();
return scheme() + "://" + encodedHost() + "/./" + pathView();
return scheme() + "://" + encodedHost() + pathView();
}
QString FilePath::toFSPathString() const
@@ -210,8 +210,8 @@ QString FilePath::toFSPathString() const
return path();
if (isRelativePath())
return specialPath(SpecialPathComponent::RootPath) + "/" + scheme() + "/" + encodedHost() + "/./" + path();
return specialPath(SpecialPathComponent::RootPath) + "/" + scheme() + "/" + encodedHost() + path();
return specialRootPath() + '/' + scheme() + '/' + encodedHost() + "/./" + pathView();
return specialRootPath() + '/' + scheme() + '/' + encodedHost() + pathView();
}
QUrl FilePath::toUrl() const
@@ -710,25 +710,28 @@ FilePath FilePath::absoluteFilePath() const
return FilePath::currentWorkingPath().resolvePath(*this);
}
QString FilePath::specialPath(SpecialPathComponent component)
const QString &FilePath::specialRootName()
{
switch (component) {
case SpecialPathComponent::RootName:
return QLatin1String("__qtc_devices__");
case SpecialPathComponent::RootPath:
return (QDir::rootPath() + "__qtc_devices__");
case SpecialPathComponent::DeviceRootName:
return QLatin1String("device");
case SpecialPathComponent::DeviceRootPath:
return QDir::rootPath() + "__qtc_devices__/device";
}
QTC_ASSERT(false, return {});
static const QString rootName = "__qtc_devices__";
return rootName;
}
FilePath FilePath::specialFilePath(SpecialPathComponent component)
const QString &FilePath::specialRootPath()
{
return FilePath::fromString(specialPath(component));
static const QString rootPath = QDir::rootPath() + u"__qtc_devices__";
return rootPath;
}
const QString &FilePath::specialDeviceRootName()
{
static const QString deviceRootName = "device";
return deviceRootName;
}
const QString &FilePath::specialDeviceRootPath()
{
static const QString deviceRootPath = QDir::rootPath() + u"__qtc_devices__/device";
return deviceRootPath;
}
FilePath FilePath::normalizedPathName() const