ShellCommand: Remove exitCode arg from finished() signal

The only 2 handlers were taking it into account and
they interpreted the non-zero exit code as a failure,
so basically they repeated the work of default
exitCodeInterpreter.

Change-Id: I9848ef0cf5ca9017f02a02ae59dc09ec426f7626
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/gitlab/gitlabclonedialog.cpp

@@ -194,9 +194,8 @@ static Utils::FilePaths scanDirectoryForFiles(const Utils::FilePath &directory)
     return result;
 }
 
-void GitLabCloneDialog::cloneFinished(bool ok, int exitCode)
+void GitLabCloneDialog::cloneFinished(bool success)
 {
-    const bool success = (ok && exitCode == 0);
     m_commandRunning = false;
     delete m_command;
     m_command = nullptr;

src/plugins/gitlab/gitlabclonedialog.h

@@ -56,7 +56,7 @@ private:
     void updateUi();
     void cloneProject();
     void cancel();
-    void cloneFinished(bool ok, int exitCode);
+    void cloneFinished(bool success);
 
     QComboBox * m_repositoryCB = nullptr;
     QCheckBox *m_submodulesCB = nullptr;