feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Avoid endless loop when setting breakpoint on functions

Browse Source 
Change-Id: I3ead86ba50d1d68a46cdc58c06684b2ac8c091c0
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
This commit is contained in:
hjk
2013-01-31 11:39:11 +01:00
parent 174baf5ea1
commit 82ab15e403
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/debugger/breakhandler.cpp
View File

@@ -1439,8 +1439,13 @@ bool BreakHandler::BreakpointItem::needsChange() const
return true; return true;
if (data.command != response.command) if (data.command != response.command)
return true; return true;
if (data.lineNumber != response.lineNumber) if (data.type == BreakpointByFileAndLine && data.lineNumber != response.lineNumber)
return true; return true;
// FIXME: Too strict, functions may have parameter lists, or not.
// if (data.type == BreakpointByFunction && data.functionName != response.functionName)
// return true;
// if (data.type == BreakpointByAddress && data.address != response.address)
// return true;
return false; return false;
} }