diff --git a/src/libs/utils/filepath.cpp b/src/libs/utils/filepath.cpp index ba91c50ce4a..800caffdd9b 100644 --- a/src/libs/utils/filepath.cpp +++ b/src/libs/utils/filepath.cpp @@ -1751,8 +1751,6 @@ QStringList FileFilter::asFindArguments(const QString &path) const if (!(filters & QDir::Hidden)) filterOptions << "!" << "-name" << ".*"; - QStringList typesToList; - QStringList filterFilesAndDirs; if (filters.testFlag(QDir::Dirs)) filterFilesAndDirs << "-type" << "d"; diff --git a/src/libs/utils/filesystemmodel.cpp b/src/libs/utils/filesystemmodel.cpp index b905da09945..777becc552a 100644 --- a/src/libs/utils/filesystemmodel.cpp +++ b/src/libs/utils/filesystemmodel.cpp @@ -862,7 +862,7 @@ bool FileSystemModel::remove(const QModelIndex &aindex) if (useFileSystemWatcher() && HostOsInfo::isWindowsHost()) { // QTBUG-65683: Remove file system watchers prior to deletion to prevent // failure due to locked files on Windows. - const QStringList watchedPaths = d->unwatchPathsAt(aindex); + d->unwatchPathsAt(aindex); } const bool success = (fileInfo.isFile() || fileInfo.isSymLink()) ? QFile::remove(path) : QDir(path).removeRecursively(); @@ -2192,6 +2192,7 @@ void FileSystemModel::setNameFilters(const QStringList &filters) // update the bypass filter to only bypass the stuff that must be kept around d->bypassFilters.clear(); // We guarantee that rootPath will stick around + // TODO: root looks unused - does it really guarantee anything? QPersistentModelIndex root(index(rootPath())); const QModelIndexList persistentList = persistentIndexList(); for (const auto &persistentIndex : persistentList) { diff --git a/src/plugins/android/androidrunner.cpp b/src/plugins/android/androidrunner.cpp index d0b8c389984..89a9d37d60d 100644 --- a/src/plugins/android/androidrunner.cpp +++ b/src/plugins/android/androidrunner.cpp @@ -162,7 +162,8 @@ void AndroidRunner::launchAVD() if (!m_target || !m_target->project()) return; - QStringList androidAbis = AndroidManager::applicationAbis(m_target); + // TODO: is this still needed? + AndroidManager::applicationAbis(m_target); // Get AVD info const IDevice::ConstPtr device = DeviceKitAspect::device(m_target->kit()); diff --git a/src/plugins/coreplugin/actionsfilter.cpp b/src/plugins/coreplugin/actionsfilter.cpp index 82099eda581..136e70a9fe7 100644 --- a/src/plugins/coreplugin/actionsfilter.cpp +++ b/src/plugins/coreplugin/actionsfilter.cpp @@ -199,10 +199,8 @@ void ActionsFilter::collectEntriesForAction(QAction *action, const QStringList &path, QList &processedMenus) { - QList entries; if (!m_enabledActions.contains(action)) return; - const QString whatsThis = action->whatsThis(); const QString text = actionText(action); if (QMenu *menu = action->menu()) { if (processedMenus.contains(menu)) diff --git a/src/plugins/cppeditor/cppquickfixes.cpp b/src/plugins/cppeditor/cppquickfixes.cpp index 7f8d6badab6..139cee2b963 100644 --- a/src/plugins/cppeditor/cppquickfixes.cpp +++ b/src/plugins/cppeditor/cppquickfixes.cpp @@ -8966,7 +8966,6 @@ private: if (constructorLocation == CppQuickFixSettings::FunctionLocation::CppFile) { implLoc = sourceLocationFor(m_class, &insertedNamespaces); implFile = m_sourceFile; - QString clazz = overview.prettyName(m_class->name()); if (m_settings->rewriteTypesinCppFile()) implCode = symbolAt(m_class, m_sourceFile, implLoc); else @@ -8997,7 +8996,6 @@ private: if (!member->defaultValue.isEmpty()) inClassDeclaration += " = " + member->defaultValue; inClassDeclaration += ", "; - QString param = member->parameterName; if (implFile) { FullySpecifiedType type = typeAt(member->type, m_class, diff --git a/src/plugins/projectexplorer/jsonwizard/jsonwizardfactory.cpp b/src/plugins/projectexplorer/jsonwizard/jsonwizardfactory.cpp index e43e284cdc9..042cb86c4be 100644 --- a/src/plugins/projectexplorer/jsonwizard/jsonwizardfactory.cpp +++ b/src/plugins/projectexplorer/jsonwizard/jsonwizardfactory.cpp @@ -145,7 +145,6 @@ QVariantMap JsonWizardFactory::loadDefaultValues(const QString &fileName) return {}; } - QList result; const Utils::FilePaths paths = searchPaths(); for (const Utils::FilePath &path : paths) { if (path.isEmpty()) @@ -378,7 +377,6 @@ JsonWizardFactory::Page JsonWizardFactory::parsePage(const QVariant &value, QStr //loadDefaultValues() and loadDefaultValues() void JsonWizardFactory::createWizardFactories() { - QString errorMessage; QString verboseLog; const QString wizardFileName = QLatin1String("wizard.json"); diff --git a/src/plugins/projectexplorer/projectexplorer.cpp b/src/plugins/projectexplorer/projectexplorer.cpp index b72bc1333b4..bd51c11e165 100644 --- a/src/plugins/projectexplorer/projectexplorer.cpp +++ b/src/plugins/projectexplorer/projectexplorer.cpp @@ -3321,7 +3321,6 @@ void ProjectExplorerPluginPrivate::updateDeployActions() enableDeployActionsContextMenu = false; } - const QString projectName = project ? project->displayName() : QString(); bool hasProjects = SessionManager::hasProjects(); m_deployAction->setEnabled(enableDeployActions); diff --git a/src/plugins/python/pythonlanguageclient.cpp b/src/plugins/python/pythonlanguageclient.cpp index f4b6a0d52fc..aa66af328f3 100644 --- a/src/plugins/python/pythonlanguageclient.cpp +++ b/src/plugins/python/pythonlanguageclient.cpp @@ -260,7 +260,6 @@ void PyLSClient::updateExtraCompilers(ProjectExplorer::Project *project, void PyLSClient::updateExtraCompilerContents(ExtraCompiler *compiler, const FilePath &file) { - const QString text = QString::fromUtf8(compiler->content(file)); const FilePath target = m_extraCompilerOutputDir.pathAppended(file.fileName()); target.writeFileContents(compiler->content(file)); diff --git a/src/plugins/qbsprojectmanager/qbsproject.cpp b/src/plugins/qbsprojectmanager/qbsproject.cpp index c9e69b5fdcb..53b5705dca4 100644 --- a/src/plugins/qbsprojectmanager/qbsproject.cpp +++ b/src/plugins/qbsprojectmanager/qbsproject.cpp @@ -296,7 +296,6 @@ bool QbsBuildSystem::renameFile(Node *context, QVariant QbsBuildSystem::additionalData(Id id) const { if (id == "QmlDesignerImportPath") { - QStringList designerImportPaths; const QJsonObject project = session()->projectData(); QStringList paths; forAllProducts(project, [&paths](const QJsonObject &product) { diff --git a/src/plugins/qmldesigner/designercore/include/abstractproperty.h b/src/plugins/qmldesigner/designercore/include/abstractproperty.h index 5afb394480d..7ac325fbd8f 100644 --- a/src/plugins/qmldesigner/designercore/include/abstractproperty.h +++ b/src/plugins/qmldesigner/designercore/include/abstractproperty.h @@ -91,7 +91,6 @@ public: template bool hasDynamicTypeName(const std::tuple &typeNames) const { - auto dynamicTypeName_ = dynamicTypeName(); return std::apply([&](auto... typeName) { return hasDynamicTypeName(typeName...); }, typeNames); } diff --git a/src/plugins/studiowelcome/qdsnewdialog.cpp b/src/plugins/studiowelcome/qdsnewdialog.cpp index da5224a292d..b2cbfce7a64 100644 --- a/src/plugins/studiowelcome/qdsnewdialog.cpp +++ b/src/plugins/studiowelcome/qdsnewdialog.cpp @@ -397,7 +397,6 @@ void QdsNewDialog::accept() .execute(); std::shared_ptr item = m_wizard.preset(); - QString customSizeName = m_qmlCustomWidth + " x " + m_qmlCustomHeight; UserPresetData preset = currentUserPresetData(m_currentPreset->displayName()); m_recentsStore.save(preset); diff --git a/src/plugins/texteditor/icodestylepreferences.cpp b/src/plugins/texteditor/icodestylepreferences.cpp index af76ce47801..6bd3dc2bf7e 100644 --- a/src/plugins/texteditor/icodestylepreferences.cpp +++ b/src/plugins/texteditor/icodestylepreferences.cpp @@ -201,12 +201,9 @@ void ICodeStylePreferences::fromSettings(const QString &category, QSettings *s) QVariantMap ICodeStylePreferences::toMap() const { - QVariantMap map; if (!currentDelegate()) return d->m_tabSettings.toMap(); - return { - {currentPreferencesKey, currentDelegateId()} - }; + return {{currentPreferencesKey, currentDelegateId()}}; } void ICodeStylePreferences::fromMap(const QVariantMap &map)