feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Lua: Use global NetworkManager to fetch

Browse Source 
Fixes crash on exit on windows after "tell a joke" as well.

Change-Id: Ie1ca0c40d9b80af7fe1b0f44ec7b8cdaa190a2cd
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Marcus Tillmanns
2024-04-23 08:49:37 +02:00
parent 9f99cf80f0
commit 836393d2ef
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/lua/bindings/fetch.cpp
View File

@@ -4,6 +4,8 @@
#include "../luaengine.h" #include "../luaengine.h"
#include "../luaqttypes.h" #include "../luaqttypes.h"
#include <utils/networkaccessmanager.h>
#include <QJsonArray> #include <QJsonArray>
#include <QJsonDocument> #include <QJsonDocument>
#include <QNetworkAccessManager> #include <QNetworkAccessManager>
@@ -51,8 +53,6 @@ void addFetchModule()
.arg(r->error()); .arg(r->error());
}); });
static QNetworkAccessManager networkAccessManager;
fetch["fetch_cb"] = [](const sol::table &options, const sol::function &callback, const sol::this_state &thisState) { fetch["fetch_cb"] = [](const sol::table &options, const sol::function &callback, const sol::this_state &thisState) {
auto url = options.get<QString>("url"); auto url = options.get<QString>("url");
@@ -70,9 +70,9 @@ void addFetchModule()
QNetworkReply *reply = nullptr; QNetworkReply *reply = nullptr;
if (method == "get") if (method == "get")
reply = networkAccessManager.get(request); reply = Utils::NetworkAccessManager::instance()->get(request);
else if (method == "post") else if (method == "post")
reply = networkAccessManager.post(request, data.toUtf8()); reply = Utils::NetworkAccessManager::instance()->post(request, data.toUtf8());
else else
throw std::runtime_error("Unknown method: " + method.toStdString()); throw std::runtime_error("Unknown method: " + method.toStdString());