From 839e7760122dd0581fd39e5c75aeb3e74314ff8a Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Mon, 25 May 2020 15:27:59 +0200 Subject: [PATCH] PE: JsonWizard: Improve handling of check boxes Only handle active user clicks as 'modified' to be able to react on (un)setting values by expressions that depend on other fields. Improves the check box handling on the "Add C++ Class" and "Add Python Class" wizards as it re-evaluates the check box state based on an expression as long the user does not actively checks the respective check box. Change-Id: I739c02b85196555c0379272005ca3b0095f7c762 Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp b/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp index 6a7ecbbcd69..acdbf4dcb6e 100644 --- a/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp +++ b/src/plugins/projectexplorer/jsonwizard/jsonfieldpage.cpp @@ -840,7 +840,7 @@ void CheckBoxField::setup(JsonFieldPage *page, const QString &name) return page->expander()->expand(m_uncheckedValue); }); - QObject::connect(w, &QCheckBox::stateChanged, page, [this, page]() { + QObject::connect(w, &QCheckBox::clicked, page, [this, page]() { m_isModified = true; setHasUserChanges(); emit page->completeChanged();